Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] config param and return values of functions in the dataset class in the tutorial #2340

Merged
merged 1 commit into from May 8, 2023

Conversation

shuheilocale
Copy link
Contributor

@shuheilocale shuheilocale commented May 6, 2023

Motivation

MMPose_Tutorial.ipynb output an error at runtime. Therefore, I fixed it.

Modification

Two modifications are as follows

  • Return value of _load_annotations()
    • The caller of the _load_annotations function expects two values to be returned, but the code before the modification returned only one value. Therefore, this was changed to return two values. However, the second return value is not used by the caller, so None is returned.
  • Metrics
    • There was no "pck/PCK@0.0" metric, so I corrected it to "PCK".

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@Tau-J Tau-J merged commit 8c737b1 into open-mmlab:dev-1.x May 8, 2023
8 checks passed
@shuheilocale shuheilocale deleted the shuheilocale/fix-tutor branch May 11, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants