Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add center alignments for draw_texts in OpencvBackendVisualizer #2958

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

AntDum
Copy link

@AntDum AntDum commented Feb 18, 2024

Motivation

This pull request addresses a gap in the OpencvBackendVisualizer class's draw_texts method. Although the docstring mentions support for "bottom," "top," and "center" alignments, the current implementation lacks the ability to center-align text. This modification aims to rectify this limitation.

Modification

I've updated the draw_texts method to support center alignment for both horizontal and vertical positioning.

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2024

CLA assistant check
All committers have signed the CLA.

@Ben-Louis Ben-Louis changed the title Add center alignments for draw_texts in OpencvBackendVisualizer [Feature] Add center alignments for draw_texts in OpencvBackendVisualizer Feb 19, 2024
@Ben-Louis Ben-Louis merged commit 10f98b5 into open-mmlab:dev-1.x Feb 19, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants