[Feature] Support 300VW Dataset #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexinch
reviewed
Apr 2, 2024
Comment on lines
176
to
182
| if __name__ == '__main__': | ||
| tester = TestFace300VWDataset() | ||
| tester.test_metainfo() | ||
| tester.test_topdown() | ||
| tester.test_bottomup() | ||
| tester.test_exceptions_and_warnings() | ||
| tester.test_annotation() |
There was a problem hiding this comment.
We should remove these test codes.
Comment on lines
168
to
173
| img = cv2.imread(instance['img_path']) | ||
| visualizer.draw_points(img, instance['keypoints'][0]) | ||
| save_path = os.path.join(vis_dir, | ||
| os.path.basename(instance['img_path'])) | ||
| assert cv2.imwrite(save_path, | ||
| img), 'facial keypoints visualization failed!' |
There was a problem hiding this comment.
If you want to test the visualizer, you can add test code here https://github.com/open-mmlab/mmpose/blob/main/tests/test_visualization/test_fast_visualizer.py. And use a temporary path instead of a real path.
xiexinch
approved these changes
Apr 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #3005 +/- ##
===========================================
- Coverage 71.74% 71.64% -0.11%
===========================================
Files 293 294 +1
Lines 20068 20124 +56
Branches 3406 3416 +10
===========================================
+ Hits 14397 14417 +20
- Misses 4853 4886 +33
- Partials 818 821 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modification
BC-breaking (Optional)
Use cases (Optional)
Checklist
Before PR:
After PR: