fix bugs in pck calculation #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innerlee
reviewed
Dec 1, 2020
| @@ -16,17 +16,20 @@ def _calc_distances(preds, targets, mask, normalize): | |||
| Args: | |||
| preds (np.ndarray[N, K, 2]): Predicted keypoint location. | |||
| targets (np.ndarray[N, K, 2]): Groundtruth keypoint location. | |||
| normalize (np.ndarray[N, 2]): Typical value is heatmap_size/10 | |||
There was a problem hiding this comment.
/10 or 0.1 should not be in normalize, but thr.
In other words, thr=0.1 and normalize=heatmap_size, is more reasonable.
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 115 115
Lines 7257 7257
Branches 1151 1151
=======================================
Hits 6085 6085
Misses 955 955
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
approved these changes
Dec 1, 2020
|
Add a test case that making the previous code error? |
|
Will add a test case soon. |
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* fix bugs in pck calculation * update notes and comments * update readme and add unit-tests
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
* clean code * fix as comment * fix as comment * add get_registry_by_scope method * add unit test and docstring example * rename get_registry_by_scope to switch_scope_and_registry * move build function to registry/builder * fix docstring * rename builder->registry_builder, move build_from_cfg to registry_builder rename builder->registry_builder, move build_from_cfg to registry_builder * rename registry_builder to build_function rename registry_builder to build_function * fix docstring and type hint * rename build_function to build_functions
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* fix bugs in pck calculation * update notes and comments * update readme and add unit-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.