Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set add_keypoint_weight=False by default, to speed up visualization. #423

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Jan 15, 2021

No description provided.

@jin-s13 jin-s13 requested a review from innerlee January 15, 2021 05:45
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #423 (cdb84b3) into master (9703521) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   81.96%   81.86%   -0.10%     
==========================================
  Files         124      124              
  Lines        8235     8245      +10     
  Branches     1330     1334       +4     
==========================================
  Hits         6750     6750              
- Misses       1203     1213      +10     
  Partials      282      282              
Flag Coverage Δ
unittests 81.86% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/detectors/bottom_up.py 60.14% <0.00%> (-2.27%) ⬇️
mmpose/models/detectors/top_down.py 62.69% <0.00%> (-2.60%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9703521...9548298. Read the comment docs.

@@ -303,6 +303,7 @@ def show_result(self,
font_scale=0.5,
win_name='',
show=False,
add_keypoint_weight=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add_keypoint_weight -> show_keypoint_weight or draw_keypoint_weight?

@innerlee innerlee merged commit 55e56ce into master Jan 15, 2021
@innerlee innerlee deleted the vis_speedup branch January 15, 2021 06:12
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
…pen-mmlab#423)

* set add_keypoint_weight=False by default, to speed up visualization.

* replace name with show_keypoint_weight
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
…ab#423)

* Support build evaluator from list of built metric

* regist evaluator

* fix as comment

* add unit test
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
…pen-mmlab#423)

* set add_keypoint_weight=False by default, to speed up visualization.

* replace name with show_keypoint_weight
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants