Interhand 3d dataset #468
Merged
Interhand 3d dataset #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 80.72% 80.99% +0.27%
==========================================
Files 137 138 +1
Lines 9156 9425 +269
Branches 1469 1510 +41
==========================================
+ Hits 7391 7634 +243
- Misses 1444 1448 +4
- Partials 321 343 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Feb 8, 2021
innerlee
reviewed
Feb 16, 2021
innerlee
reviewed
Feb 16, 2021
innerlee
reviewed
Feb 16, 2021
|
kindly ping @liuxin9608 |
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
innerlee
reviewed
Feb 19, 2021
| gts_hand_type.append(item['hand_type']) | ||
| hand_type_masks.append(item['hand_type_valid'] > 0) | ||
|
|
||
| gts_rel_root = np.array(gts_rel_root) |
There was a problem hiding this comment.
Make the datatype explict
There was a problem hiding this comment.
Is it really necessary?
There was a problem hiding this comment.
The dtype of each item in the list has explicitly assigned.
There was a problem hiding this comment.
E.g., there are some variables with mask in their names. Then one may wonder what their types are: bool? int? float32?
There was a problem hiding this comment.
The type can be changed if the append operation is not careful. e.g.
|
Some minor comments. How about the training accuracy? When will the ckpts be ready? |
The training has not started yet. There are also many PRs to commit before training. |
|
I see. If more prs are needed for training, then we can simply merge this, and block on the last pr. |
innerlee
approved these changes
Feb 19, 2021
rollingman1
pushed a commit
to rollingman1/mmpose
that referenced
this pull request
Nov 5, 2021
* resolve comments * update changelog * + sparse demo * fix bug * add doc for the new arg * update changelog * reorg code in long demo * add a comment * resolve comments Co-authored-by: Jintao Lin <528557675@qq.com>
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
HAOCHENYE
added a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
…n-mmlab#468) * [Refactor]: modify interface of Visualizer.add_datasample (open-mmlab#365) * [Refactor] Refactor data flow: refine `data_preprocessor`. (open-mmlab#359) * refine data_preprocessor * remove unused BATCH_DATA alias * Fix type hints * rename move_data to cast_data * [Refactor] Refactor data flow: collate data in `collate_fn` of `DataLoader` (open-mmlab#323) * acollate data in dataloader * fix docstring * refine comment * fix as comment * refactor default collate and psedo collate * foramt test file * fix docstring * fix as comment * rename elem to data_item * minor fix * fix as comment * [Refactor] Refactor data flow: `data_batch` argument of `Evaluator.process is a `dict` (open-mmlab#360) * refine evaluator and metric * compatible with new default collate * replace default collate with pseudo * Handle data_batch in metric * fix unit test * fix unit test * fix unit test * minor refine * make data_batch optional make data_batch optional * rename outputs to predictions * fix ut * rename predictions to outputs * fix docstring * fix docstring * fix unit test * make outputs and data_batch to kwargs * fix unit test * keep signature of metric * fix ut * rename pred_sample arguments to data_sample(Visualizer) * fix loop and ut * [refactor]: Refactor model dataflow (open-mmlab#398) * [Refactor] Refactor data flow: refine `data_preprocessor`. (open-mmlab#359) * refine data_preprocessor * remove unused BATCH_DATA alias * Fix type hints * rename move_data to cast_data * refactor model data flow tmp_commt tmp commit * make val_cfg and test_cfg optional * roll back runner * pass test mmdet * fix as comment fix as comment fix ci in DataPreprocessor * fix ut * fix ut * fix rebase main * [Fix]: Fix test val ddp (open-mmlab#462) * [Fix] Fix docstring and type hint of data flow (open-mmlab#463) * Fix docstring of data flow * change signature of hook * fix unit test * resolve conflicts * fix lint
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.