Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decode #481

Merged
merged 2 commits into from Feb 26, 2021
Merged

add decode #481

merged 2 commits into from Feb 26, 2021

Conversation

liuxin9608
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #481 (315d0ac) into master (b382ee7) will increase coverage by 0.41%.
The diff coverage is 86.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   80.64%   81.06%   +0.41%     
==========================================
  Files         137      138       +1     
  Lines        9201     9479     +278     
  Branches     1480     1519      +39     
==========================================
+ Hits         7420     7684     +264     
+ Misses       1454     1451       -3     
- Partials      327      344      +17     
Flag Coverage Δ
unittests 80.96% <83.73%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/evaluation/top_down_eval.py 57.42% <ø> (ø)
mmpose/core/post_processing/group.py 82.63% <ø> (ø)
mmpose/core/post_processing/post_transforms.py 86.59% <ø> (ø)
mmpose/datasets/builder.py 52.50% <ø> (ø)
mmpose/datasets/pipelines/top_down_transform.py 57.66% <0.00%> (ø)
mmpose/datasets/samplers/distributed_sampler.py 29.41% <25.00%> (ø)
mmpose/models/keypoint_heads/fc_head.py 57.53% <50.00%> (ø)
...pose/datasets/datasets/hand/interhand3d_dataset.py 86.09% <86.09%> (ø)
mmpose/datasets/pipelines/shared_transform.py 86.50% <92.72%> (+3.01%) ⬆️
mmpose/datasets/datasets/__init__.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b382ee7...05b6730. Read the comment docs.

- "rotation": rotation of the bbox
- "bbox_score": score of bbox
output (np.ndarray[N, K, H, W]): model predicted heatmaps.
kwargs: dict contains 'img_size'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just add img_size to argument list?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is part of interface refactoring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not sure about this. Leave it to future revision

@innerlee innerlee merged commit 7f81a58 into master Feb 26, 2021
@innerlee innerlee deleted the add_decode branch February 26, 2021 15:41
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* add decode

* rename decode_keypoints to decode

Co-authored-by: jinsheng <jinsheng@sensetime.com>
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* add introduction of mmengine in get_started.md

* resolve comments

* resolve comments

* resolve comments

* resolve comments

* resolve comments

* resolve comments

* update figs
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* add decode

* rename decode_keypoints to decode

Co-authored-by: jinsheng <jinsheng@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants