add PhotometricDistortion #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 80.99% 81.05% +0.05%
==========================================
Files 138 138
Lines 9425 9474 +49
Branches 1510 1518 +8
==========================================
+ Hits 7634 7679 +45
- Misses 1448 1451 +3
- Partials 343 344 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Feb 22, 2021
|
|
||
|
|
||
| @PIPELINES.register_module() | ||
| class PhotoMetricDistortion(object): |
There was a problem hiding this comment.
PhotoMetric -> Photometric
It is derived from word photometry
There was a problem hiding this comment.
Actually, PhotoMetricDistortion is copied from mmdet. Shall we keep the name the same?
There was a problem hiding this comment.
We can raise an issue there~
innerlee
reviewed
Feb 22, 2021
innerlee
reviewed
Feb 22, 2021
innerlee
reviewed
Feb 22, 2021
innerlee
reviewed
Feb 23, 2021
innerlee
reviewed
Feb 23, 2021
|
Nevermind, let's consider optimization later. |
innerlee
reviewed
Feb 23, 2021
| 5. random hue | ||
| 6. convert color from HSV to BGR | ||
| 7. random contrast (mode 1) | ||
| 8. randomly swap channels |
innerlee
approved these changes
Feb 24, 2021
shuheilocale
pushed a commit
to shuheilocale/mmpose
that referenced
this pull request
May 6, 2023
* add PhotoMetricDistortion * update saturation_hue * remove (object) * mv dice to call * add random swap channels
HAOCHENYE
pushed a commit
to HAOCHENYE/mmpose
that referenced
this pull request
Jun 27, 2023
ajgrafton
pushed a commit
to ajgrafton/mmpose
that referenced
this pull request
Mar 6, 2024
* add PhotoMetricDistortion * update saturation_hue * remove (object) * mv dice to call * add random swap channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.