Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittest #529

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Fix unittest #529

merged 2 commits into from
Mar 24, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Mar 23, 2021

No description provided.

@jin-s13 jin-s13 requested a review from innerlee March 23, 2021 11:20
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #529 (70d08af) into master (0bd81c8) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 70d08af differs from pull request most recent head a20fa80. Consider uploading reports for the commit a20fa80 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   81.16%   81.20%   +0.04%     
==========================================
  Files         139      139              
  Lines        9572     9572              
  Branches     1530     1530              
==========================================
+ Hits         7769     7773       +4     
+ Misses       1458     1455       -3     
+ Partials      345      344       -1     
Flag Coverage Δ
unittests 81.10% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...datasets/datasets/top_down/topdown_coco_dataset.py 89.09% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd81c8...a20fa80. Read the comment docs.

@innerlee
Copy link
Contributor

innerlee commented Mar 24, 2021

Need to add docstring for the function, since I cannot guess what's the implication of is_3d

Nevermind, its a util function for tests

@innerlee innerlee merged commit f51cc2b into master Mar 24, 2021
@jin-s13 jin-s13 deleted the fix_unittest branch March 25, 2021 02:43
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* fix visible in unittest

* fix visible in unittest
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* fix visible in unittest

* fix visible in unittest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants