-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bugs in bottom-up keypoint score #548
Conversation
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 82.08% 82.03% -0.05%
==========================================
Files 150 150
Lines 10199 10199
Branches 1623 1623
==========================================
- Hits 8372 8367 -5
- Misses 1450 1453 +3
- Partials 377 379 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Adding a unittest for this error would be great |
And, does this change affect any scores in modelzoo? |
This bug is caused by upgrading xtcocotools (in the newer version of xtcocotools, those keypoints with zero-score will be ignored.) |
Note for future readers: Please use mmpose >= v0.13.0 if you use xtcocotools >= 1.7 |
* homepage Signed-off-by: lizz <lizz@sensetime.com> * Dataset overview Signed-off-by: lizz <lizz@sensetime.com> * Fix Signed-off-by: lizz <lizz@sensetime.com>
Setting all joint scores to be 0 would cause erroneous results in testing for bottom-up approach