Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in bottom-up keypoint score #548

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix bugs in bottom-up keypoint score #548

merged 1 commit into from
Mar 31, 2021

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Mar 31, 2021

Setting all joint scores to be 0 would cause erroneous results in testing for bottom-up approach

@wusize wusize requested a review from jin-s13 March 31, 2021 13:40
@jin-s13 jin-s13 requested a review from innerlee March 31, 2021 13:43
@jin-s13 jin-s13 changed the title fix a bug fix bug in bottom-up keypoint score Mar 31, 2021
@jin-s13 jin-s13 changed the title fix bug in bottom-up keypoint score fix bugs in bottom-up keypoint score Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #548 (9caf8e5) into master (6ff9938) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 9caf8e5 differs from pull request most recent head fdc4a2b. Consider uploading reports for the commit fdc4a2b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   82.08%   82.03%   -0.05%     
==========================================
  Files         150      150              
  Lines       10199    10199              
  Branches     1623     1623              
==========================================
- Hits         8372     8367       -5     
- Misses       1450     1453       +3     
- Partials      377      379       +2     
Flag Coverage Δ
unittests 81.95% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/core/post_processing/post_transforms.py 95.04% <100.00%> (ø)
mmpose/datasets/pipelines/shared_transform.py 83.52% <0.00%> (-2.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff9938...fdc4a2b. Read the comment docs.

@innerlee
Copy link
Contributor

Adding a unittest for this error would be great

@innerlee
Copy link
Contributor

And, does this change affect any scores in modelzoo?

@jin-s13
Copy link
Collaborator

jin-s13 commented Mar 31, 2021

This bug is caused by upgrading xtcocotools (in the newer version of xtcocotools, those keypoints with zero-score will be ignored.)

@innerlee
Copy link
Contributor

Note for future readers: Please use mmpose >= v0.13.0 if you use xtcocotools >= 1.7

@innerlee innerlee merged commit 5b30053 into master Mar 31, 2021
@innerlee innerlee deleted the bug_in_postprocess branch March 31, 2021 16:20
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* homepage

Signed-off-by: lizz <lizz@sensetime.com>

* Dataset overview

Signed-off-by: lizz <lizz@sensetime.com>

* Fix

Signed-off-by: lizz <lizz@sensetime.com>
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants