Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom up pose tracking demo #574

Merged
merged 9 commits into from Apr 28, 2021
Merged

Conversation

HoBeom
Copy link
Contributor

@HoBeom HoBeom commented Apr 15, 2021

ADD Bottom up pose tracking demo
I need your review. 馃槃
Some docs may be misplaced. I'm sorry. 馃槩

  1. ADD Bottom up pose tracking demo
  2. I add an OKS similarity comparison.
  3. One-Euro-Filter used by VNect is added for smoothing. 馃槷
    Performance is similar on the Posetrack 2018 VAL (HRNetw32_256x192).
    No filter : Total AP: 83.27367136220447
    filtered : Total AP, 83.29611050229873
  • I separated this code from my complex code separately.
    This branch was made for push and was not tested.
    I believe your review will improve me.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #574 (43565a5) into master (a63b148) will decrease coverage by 0.28%.
The diff coverage is 66.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   83.06%   82.78%   -0.29%     
==========================================
  Files         165      167       +2     
  Lines       11689    11963     +274     
  Branches     1881     1927      +46     
==========================================
+ Hits         9709     9903     +194     
- Misses       1518     1574      +56     
- Partials      462      486      +24     
Flag Coverage 螖
unittests 82.78% <66.33%> (-0.20%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
mmpose/models/detectors/bottom_up.py 60.14% <酶> (酶)
mmpose/apis/inference_tracking.py 63.63% <39.28%> (-22.28%) 猬囷笍
mmpose/core/post_processing/__init__.py 100.00% <100.00%> (酶)
mmpose/core/post_processing/one_euro_filter.py 100.00% <100.00%> (酶)
mmpose/datasets/pipelines/shared_transform.py 81.50% <0.00%> (-7.00%) 猬囷笍
mmpose/datasets/pipelines/top_down_transform.py 62.42% <0.00%> (-1.19%) 猬囷笍
mmpose/apis/inference.py 48.41% <0.00%> (-1.19%) 猬囷笍
mmpose/datasets/pipelines/mesh_transform.py 94.31% <0.00%> (-1.14%) 猬囷笍
mmpose/models/detectors/top_down.py 58.15% <0.00%> (酶)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a63b148...43565a5. Read the comment docs.

@jin-s13
Copy link
Collaborator

jin-s13 commented Apr 15, 2021

Thanks a lot for your contribution锛乄e will take a look.

@jin-s13 jin-s13 requested a review from ly015 April 20, 2021 11:44
@ly015
Copy link
Member

ly015 commented Apr 22, 2021

And could you please rebase your branch onto master? The demo folder has been reorganized in #592 so there are conflicts that need to be manually resolved.

@HoBeom
Copy link
Contributor Author

HoBeom commented Apr 23, 2021

I can't work right away because I'm on a business trip. I'll be working on it next week. 馃槶

@ly015
Copy link
Member

ly015 commented Apr 26, 2021

Many thanks for the update, and we are almost done. Currently, the codecov rate is below the target, mainly due to the uncovered modification in apis/inference_tracking.py. Could you please add a piece of code into tests/test_api/test_inference_tracking.py to test the bottom-up tracking function (Copying the core part of bottom_up_pose_tracking_demo.py into test_inference_tracking should do it. You can follow the examples in test_inference_tracking.py) This would be very helpful for double-checking the function and future developments.

@HoBeom
Copy link
Contributor Author

HoBeom commented Apr 27, 2021

I wrote code to test the functions added in tracking by referring to tests/test_api/test_inference.py.

@ly015 ly015 closed this Apr 27, 2021
@ly015 ly015 reopened this Apr 27, 2021
@ly015 ly015 merged commit d56465a into open-mmlab:master Apr 28, 2021
minoki pushed a commit to minoki/mmpose that referenced this pull request Jul 13, 2021
* Bottom up pose tracking demo

* UPDATE Bottom up pose tracking demo

* HOT FIX

* FIX ARGS oks-thr, iou-thr

* ADD unittest

* HOT FIX

* TEST codecov

* update demo README

Co-authored-by: ly015 <liyining0712@gmail.com>
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* Bottom up pose tracking demo

* UPDATE Bottom up pose tracking demo

* HOT FIX

* FIX ARGS oks-thr, iou-thr

* ADD unittest

* HOT FIX

* TEST codecov

* update demo README

Co-authored-by: ly015 <liyining0712@gmail.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* Bottom up pose tracking demo

* UPDATE Bottom up pose tracking demo

* HOT FIX

* FIX ARGS oks-thr, iou-thr

* ADD unittest

* HOT FIX

* TEST codecov

* update demo README

Co-authored-by: ly015 <liyining0712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants