Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change ALGORITHM tag into comment #580

Merged
merged 6 commits into from
Apr 19, 2021
Merged

change ALGORITHM tag into comment #580

merged 6 commits into from
Apr 19, 2021

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Apr 16, 2021

No description provided.

@ly015 ly015 requested a review from innerlee April 16, 2021 08:27
@innerlee
Copy link
Contributor

Have you tested locally?

@ly015
Copy link
Member Author

ly015 commented Apr 16, 2021

The docs have been autoformatted accidentally. I will push a commit to fix it.

@codecov
Copy link

codecov bot commented Apr 16, 2021 •
edited
Loading

Codecov Report

Merging #580 (6ce1ec7) into master (43fdac4) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   82.67%   82.31%   -0.37%     
==========================================
  Files         164      164              
  Lines       11476    11374     -102     
  Branches     1854     1855       +1     
==========================================
- Hits         9488     9362     -126     
- Misses       1530     1542      +12     
- Partials      458      470      +12
Flag Coverage Δ
unittests 82.31% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/datasets/pipelines/shared_transform.py 76.68% <0.00%> (-9.79%) ⬇️
mmpose/datasets/dataset_wrappers.py 50.00% <0.00%> (-4.55%) ⬇️
mmpose/datasets/datasets/mesh/mesh_mix_dataset.py 86.95% <0.00%> (-4.35%) ⬇️
mmpose/models/detectors/base.py 54.76% <0.00%> (-3.94%) ⬇️
mmpose/datasets/datasets/mesh/mesh_h36m_dataset.py 22.41% <0.00%> (-2.59%) ⬇️
mmpose/core/fp16/hooks.py 25.00% <0.00%> (-2.28%) ⬇️
mmpose/datasets/pipelines/top_down_transform.py 55.34% <0.00%> (-2.20%) ⬇️
mmpose/core/camera/camera_base.py 78.57% <0.00%> (-1.43%) ⬇️
mmpose/datasets/pipelines/mesh_transform.py 94.11% <0.00%> (-1.34%) ⬇️
mmpose/datasets/datasets/face/face_base_dataset.py 76.47% <0.00%> (-1.31%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fdac4...6ce1ec7. Read the comment docs.

@innerlee
Copy link
Contributor

The formatting is okay to me. Pls run

cd docs
make html

and check the generated htmls are good.

@ly015
Copy link
Member Author

ly015 commented Apr 16, 2021

The formatting is okay to me. Pls run

cd docs
make html

and check the generated htmls are good.

The locally built htmls look good to me, except that the model-zoo overview page is not generated so we don't known if the algorithm counts are correct.

@innerlee
Copy link
Contributor

The important thing is the modelzoo

@innerlee
Copy link
Contributor

The important thing is the modelzoo, which is the sole purpose of the tag

@innerlee
Copy link
Contributor

Please also change the [backbone], [dataset], etc.

innerlee and others added 2 commits April 19, 2021 15:08
@innerlee
Copy link
Contributor

The linting failed btw

@innerlee innerlee merged commit 656405a into open-mmlab:master Apr 19, 2021
@ly015 ly015 deleted the algorithm_tag branch April 19, 2021 19:03
@innerlee innerlee mentioned this pull request Apr 20, 2021
Merged
minoki pushed a commit to minoki/mmpose that referenced this pull request Jul 13, 2021
@ly015 @innerlee @minoki
change ALGORITHM tag into comment (open-mmlab#580)
022d1d5 
* change ALGORITHM tag into comment

* Revert "change ALGORITHM tag into comment"

This reverts commit fb4402e.

* comment algorithm tag

* Hide paper type annotation

Signed-off-by: lizz <lizz@sensetime.com>

* update DATASET and BACKBONE tags

* fix linting

Co-authored-by: lizz <lizz@sensetime.com>
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
@kennymckormick
Add changelog (open-mmlab#580)
616e819 
* resolve comments

* update changelog

* update changelog
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@ly015 @innerlee
change ALGORITHM tag into comment (open-mmlab#580)
a02fc98 
* change ALGORITHM tag into comment

* Revert "change ALGORITHM tag into comment"

This reverts commit fb4402e.

* comment algorithm tag

* Hide paper type annotation

Signed-off-by: lizz <lizz@sensetime.com>

* update DATASET and BACKBONE tags

* fix linting

Co-authored-by: lizz <lizz@sensetime.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@ly015 @innerlee
change ALGORITHM tag into comment (open-mmlab#580)
7bf23ac 
* change ALGORITHM tag into comment

* Revert "change ALGORITHM tag into comment"

This reverts commit fb4402e.

* comment algorithm tag

* Hide paper type annotation

Signed-off-by: lizz <lizz@sensetime.com>

* update DATASET and BACKBONE tags

* fix linting

Co-authored-by: lizz <lizz@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerlee innerlee innerlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ly015 @innerlee