Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex dependency #720

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Add regex dependency #720

merged 1 commit into from
Jun 11, 2021

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Jun 11, 2021

In titlecase>=2.1.0, if regex is not successfully imported, re will be imported as regex, which may lead to unexpected behavior or errors. So we add regex into the requirements explicitly.

@ly015 ly015 requested review from innerlee and jin-s13 June 11, 2021 08:15
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #720 (a5dbc51) into master (c20bc0d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files         168      168           
  Lines       12810    12810           
  Branches     2082     2082           
=======================================
  Hits        10627    10627           
  Misses       1648     1648           
  Partials      535      535           
Flag Coverage Δ
unittests 82.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20bc0d...a5dbc51. Read the comment docs.

@ly015 ly015 merged commit c8ff23f into open-mmlab:master Jun 11, 2021
@ly015 ly015 deleted the fix_doc branch July 5, 2021 02:50
minoki pushed a commit to minoki/mmpose that referenced this pull request Jul 13, 2021
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* resolve comments

* update changelog

* support torchvision backbones

* add ckpt, changelog and unittest

* fix lint

* fix lint

* fix lint

* Update changelog.md

* Update changelog.md
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* Translate runner

* minor refine

* update two-column table wrapper

* minor refine

* update chinese

* refine chinese runner

* Apply suggestions from code review

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Qian Zhao <112053249+C1rN09@users.noreply.github.com>
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants