Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] ignore _base_ in collections #916

Merged
merged 2 commits into from
Sep 15, 2021
Merged

[Fix] ignore _base_ in collections #916

merged 2 commits into from
Sep 15, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Sep 14, 2021 •
edited
Loading

Motivation

Ignore base configs when counting ckpt/cfg.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 requested a review from ly015 September 14, 2021 05:17
@jin-s13 jin-s13 changed the title ignore _base_ in collections [Fix] ignore _base_ in collections Sep 15, 2021
@ly015 ly015 merged commit b18e7b8 into master Sep 15, 2021
@innerlee innerlee deleted the fix_modelzoo branch September 16, 2021 10:12
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
@kennymckormick
Merge pull request open-mmlab#916 from dreamerlin/scheduler
f007661 
[Improvement] Rename `lr` modules to `scheduler`
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@jin-s13
[Fix] ignore _base_ in collections (open-mmlab#916)
27b8122 
* ignore _base_ in collections

* fix collect in docs_zh-CN
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@jin-s13
[Fix] ignore _base_ in collections (open-mmlab#916)
73fd66f 
* ignore _base_ in collections

* fix collect in docs_zh-CN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly015 ly015 ly015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jin-s13 @ly015