Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Fix requirements. #936

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Sep 23, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

trimesh was imported after #771 and was added into optional.txt. However, it dit not using try to avoid rasing error when not installing this package. This led to the failure of CI for downstream projects.

Modification

Add trimesh and poseval to requirements/runtime.txt

BC-breaking (Optional)

None.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015
Copy link
Member

ly015 commented Sep 23, 2021

Will other dependencies in optional.txt lead to the same problem in downstream projects, e.g. pyrender?

@RangiLyu
Copy link
Member Author

RangiLyu commented Sep 23, 2021

Will other dependencies in optional.txt lead to the same problem in downstream projects, e.g. pyrender?

try:
os.environ['PYOPENGL_PLATFORM'] = 'osmesa'
import pyrender
has_pyrender = True
except (ImportError, ModuleNotFoundError):
has_pyrender = False

These lines avoid this problem.

But poseval will cause the same issue. I think the packages which imported without using try&except should move to runtime. But onnx and onnxruntime are only used in tools, no need to move.

@ly015 ly015 merged commit b606986 into open-mmlab:master Sep 28, 2021
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* [Fix]: Fix requirements

* [Fix]: Fix requirements
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* [Fix]: Fix requirements

* [Fix]: Fix requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants