Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support multiple settings for data_loader #946

Merged
merged 4 commits into from
Sep 30, 2021
Merged

[Feature] Support multiple settings for data_loader #946

merged 4 commits into from
Sep 30, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Sep 30, 2021

Fix #923

the bugs in #926 are fixed

Related PRs: open-mmlab/mmocr#459

Motivation

Follow https://github.com/open-mmlab/mmocr/blob/main/mmocr/apis/train.py to refactor the collection of the config for training/testing.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@jin-s13 jin-s13 requested a review from ly015 September 30, 2021 05:35
@ly015 ly015 merged commit 1c8cc0f into master Sep 30, 2021
@jin-s13 jin-s13 deleted the persistent_workers branch October 8, 2021 04:45
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
@dreamerlin
Support efficient video decoder and PIMS decoder (open-mmlab#946)
1f9dedc 
* update video decoder

* update unittest and docstring

* add requirements

* docstring

* Update test_decode.py
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@jin-s13
[Feature] Support multiple settings for data_loader (open-mmlab#946)
2ba0e33 
* mmocr-style cfg

* fix **

* fix dict

* fix dict
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@jin-s13
[Feature] Support multiple settings for data_loader (open-mmlab#946)
5596bc3 
* mmocr-style cfg

* fix **

* fix dict

* fix dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly015 ly015 ly015 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a dataset bug causing topdown training very slow, wasting 3 min every epoch
2 participants
@jin-s13 @ly015