Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix bug in mmpose/apis/train.py #970

Merged
merged 1 commit into from
Oct 14, 2021
Merged

[Fix] fix bug in mmpose/apis/train.py #970

merged 1 commit into from
Oct 14, 2021

Conversation

liqikai9
Copy link
Collaborator

Motivation

Fix #959, a bug related to the default value of dataloader_setting in mmpose/apis/train.py.

Modification

  1. In mmpose/apis/train.py, change the default value of workers_per_gpu from {} to integer 1

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@liqikai9 liqikai9 requested a review from jin-s13 October 14, 2021 03:28
@ly015 ly015 changed the title [Fix] fix bug in mmpose/apis/train.py #959 [Fix] fix bug in mmpose/apis/train.py Oct 14, 2021
@ly015 ly015 merged commit 98509cb into open-mmlab:master Oct 14, 2021
@liqikai9 liqikai9 deleted the bug_fix_959 branch March 8, 2022 07:59
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
@liqikai9
fix bug in dataloader_setting (open-mmlab#970)
23fc2d7
HAOCHENYE added a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
@HAOCHENYE @zhouzaida
[Fix] Support calculate the flops of matmul with single dimension m…
8beacd3 
…atrix (open-mmlab#970)

* Support calculate the flops of matmul

* Remove unnecessary type ignore

* Update mmengine/analysis/jit_handles.py

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>

---------

Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
@liqikai9
fix bug in dataloader_setting (open-mmlab#970)
a712230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ly015 ly015 ly015 approved these changes

@jin-s13 jin-s13 Awaiting requested review from jin-s13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Possible bug in mmpose/apis/train.py
2 participants
@liqikai9 @ly015