Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix duplicate keypoint name #976

Merged
merged 2 commits into from
Oct 19, 2021
Merged

[Fix] Fix duplicate keypoint name #976

merged 2 commits into from
Oct 19, 2021

Conversation

jin-s13
Copy link
Collaborator

@jin-s13 jin-s13 commented Oct 18, 2021

Motivation

Fix duplicate keypoint name (left_wrist, and right_wrist have been used twice.) I rename one of them to left_hand_root/right_hand_root.

Modification

Rename base/datasets/coco_wholebody.py

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@ly015 ly015 merged commit daf8082 into master Oct 19, 2021
@ly015 ly015 changed the title Fix duplicate keypoint name [Fix] Fix duplicate keypoint name Oct 19, 2021
@jin-s13 jin-s13 deleted the fix_duplicate_name branch October 25, 2021 05:59
rollingman1 pushed a commit to rollingman1/mmpose that referenced this pull request Nov 5, 2021
* support posec3d_demo

* add label map

* fix bug

* update readme

* update readme

* update README

* update demo

* update
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
* fix duplicate keypoint name

* update keypoint name
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
* enable compile configurations to support torch.compile in Runner

* enable compilation in train, val and test

* fix as comments

* add docstring to illustrate usage

* minor refine error message

* add unittests

* fix ut skip

* add logging message to inform users

* compile `train_step`, `val_step`, `test_step` instead

* fix as comments

* revert to compile `train_step` only due to pt2 issue

* add documentation about torch.compile
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
* fix duplicate keypoint name

* update keypoint name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants