Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix heatmap and tag size mismatch in bottom-up with udp #994

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Oct 28, 2021

Motivation

Tag-map size and heatmap size are not aligned for udp in bottom-up approaches.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@wusize wusize requested a review from luminxu October 28, 2021 14:46
@jin-s13 jin-s13 added the Bug:P1 label Oct 28, 2021
@jin-s13 jin-s13 self-requested a review October 28, 2021 14:49
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #994 (2b9867d) into master (2b4a5cf) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   82.72%   82.70%   -0.02%     
==========================================
  Files         190      190              
  Lines       14190    14197       +7     
  Branches     2439     2441       +2     
==========================================
+ Hits        11739    11742       +3     
- Misses       1828     1832       +4     
  Partials      623      623              
Flag Coverage Δ
unittests 82.63% <28.57%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/models/detectors/associative_embedding.py 72.72% <28.57%> (-2.48%) ⬇️
mmpose/datasets/pipelines/shared_transform.py 87.56% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4a5cf...2b9867d. Read the comment docs.

@ly015 ly015 merged commit ff528c7 into master Oct 29, 2021
@ly015 ly015 changed the title [Bug fix]Resize for udp [Bug] Fix heatmap and tag sizes mismatch in bottom-up with udp Oct 29, 2021
@ly015 ly015 changed the title [Bug] Fix heatmap and tag sizes mismatch in bottom-up with udp [Bug] Fix heatmap and tag size mismatch in bottom-up with udp Oct 29, 2021
@wusize wusize deleted the resize_for_udp branch November 1, 2021 04:29
shuheilocale pushed a commit to shuheilocale/mmpose that referenced this pull request May 6, 2023
HAOCHENYE pushed a commit to HAOCHENYE/mmpose that referenced this pull request Jun 27, 2023
ajgrafton pushed a commit to ajgrafton/mmpose that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants