Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add retrieval mAP #1552

Merged
merged 11 commits into from
May 26, 2023
Merged

[Feature] Add retrieval mAP #1552

merged 11 commits into from
May 26, 2023

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented May 8, 2023

Motivation

  1. Add retrieval mAP and unit tests relate to update metric mAP@k for image retrieval #980

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 21.51% and project coverage change: -1.00 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (d892028) 67.17%.

❗ Current head d892028 differs from pull request most recent head 315311e. Consider uploading reports for the commit 315311e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1552      +/-   ##
==========================================
- Coverage   68.16%   67.17%   -1.00%     
==========================================
  Files         295      303       +8     
  Lines       23372    23910     +538     
  Branches     3713     3786      +73     
==========================================
+ Hits        15932    16062     +130     
- Misses       6880     7283     +403     
- Partials      560      565       +5     
Flag Coverage Δ
unittests 67.17% <21.51%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/apis/image_retrieval.py 21.42% <ø> (ø)
mmpretrain/datasets/__init__.py 70.27% <0.00%> (-4.02%) ⬇️
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/nocaps.py 0.00% <0.00%> (ø)
mmpretrain/datasets/scienceqa.py 0.00% <ø> (ø)
mmpretrain/models/multimodal/__init__.py 40.00% <0.00%> (-4.45%) ⬇️
...retrain/models/multimodal/chinese_clip/__init__.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/bert.py 0.00% <0.00%> (ø)
...ain/models/multimodal/chinese_clip/chinese_clip.py 0.00% <0.00%> (ø)
mmpretrain/models/multimodal/chinese_clip/utils.py 0.00% <0.00%> (ø)
... and 13 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ezra-Yu Ezra-Yu requested a review from fangyixiao18 May 9, 2023 02:44
@mzr1996 mzr1996 merged commit 1f07c92 into open-mmlab:dev May 26, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants