Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add support for vsr dataset #1634

Merged
merged 3 commits into from Jun 15, 2023

Conversation

yyk-wew
Copy link
Contributor

@yyk-wew yyk-wew commented Jun 12, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add support for vsr dataset.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2023

CLA assistant check
All committers have signed the CLA.

@fangyixiao18
Copy link
Collaborator

Please sign CLA @yyk-wew @ZhangYuanhan-AI

@yyk-wew
Copy link
Contributor Author

yyk-wew commented Jun 15, 2023

Please sign CLA @yyk-wew

Done

@fangyixiao18 fangyixiao18 changed the title Add support for vsr dataset [Feature] Add support for vsr dataset Jun 15, 2023
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 43.74% and project coverage change: -1.23 ⚠️

Comparison is base (f9dcae2) 68.16% compared to head (ed12766) 66.94%.

❗ Current head ed12766 differs from pull request most recent head 609199c. Consider uploading reports for the commit 609199c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1634      +/-   ##
==========================================
- Coverage   68.16%   66.94%   -1.23%     
==========================================
  Files         295      310      +15     
  Lines       23372    24629    +1257     
  Branches     3713     3906     +193     
==========================================
+ Hits        15932    16487     +555     
- Misses       6880     7538     +658     
- Partials      560      604      +44     
Flag Coverage Δ
unittests 66.94% <43.74%> (-1.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpretrain/apis/image_retrieval.py 21.42% <ø> (ø)
mmpretrain/datasets/__init__.py 65.00% <0.00%> (-9.29%) ⬇️
mmpretrain/datasets/gqa_dataset.py 0.00% <0.00%> (ø)
mmpretrain/datasets/nocaps.py 0.00% <0.00%> (ø)
mmpretrain/datasets/ocr_vqa.py 0.00% <0.00%> (ø)
mmpretrain/datasets/scienceqa.py 0.00% <0.00%> (ø)
mmpretrain/datasets/textvqa.py 0.00% <0.00%> (ø)
mmpretrain/datasets/vsr.py 0.00% <0.00%> (ø)
mmpretrain/models/classifiers/image.py 89.83% <0.00%> (-3.16%) ⬇️
mmpretrain/models/multimodal/__init__.py 40.00% <0.00%> (-4.45%) ⬇️
... and 32 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fangyixiao18 fangyixiao18 merged commit 7581b76 into open-mmlab:dev Jun 15, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants