Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-340] New Version of config Adapting MobileNet Algorithm #1774

Merged
merged 3 commits into from Sep 1, 2023

Conversation

DE009
Copy link
Contributor

@DE009 DE009 commented Aug 25, 2023

New Version of config Adapting MobileNet Algorithm, based on open-mmlab/OpenMMLabCamp#340

Motivation

MMEngine has introduced a novel configuration mechanism, utilizing which we will perform configuration file adaptation.

Modification

Add 3 config python files in mmpretrain/configs/base/datasets/
Add 2 config python files in mmpretrain/configs/base/models/
Add 2 config python files in mmpretrain/configs/base/schedules/
Add 1 config python files in mmpretrain/configs/mobilenet_v2/
Add 5 config python files in mmpretrain/configs/mobilenet_v3/
Remove folder mmpretrain/configs/base/models/mobilenet_v3/

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2023

CLA assistant check
All committers have signed the CLA.

@OpenMMLab-Assistant-004

Hi @DE009,

We'd like to express our appreciation for your valuable contributions to the mmpretrain. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the folder _base_/models/mobilenet_v3, but only keep one file to set model config like mobilenet_v3_small.py, and the training configs of mobile net v3 all inherit from this mobilenet_v3_small.py file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can refer to mmpretrain/configs/vision_transformer, to find some examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the folder _base_/models/mobilenet_v3
add base model config file mobilenet_v3_small.py in _base_/models/
modified all training configs of mobile net v3 in folder mmpretrain/configs/mobilenet_v3/ to inheri the base model config mobilenet_v3_small.py

@fangyixiao18
Copy link
Collaborator

please update these base file and training configs in mmpretrain/configs/mobilenet_v3

@codecov
Copy link

codecov bot commented Aug 30, 2023

@fangyixiao18 fangyixiao18 merged commit 845b462 into open-mmlab:main Sep 1, 2023
8 of 9 checks passed
mzr1996 added a commit that referenced this pull request Oct 25, 2023
* [CodeCamp2023-584]Support DINO self-supervised learning in project (#1756)

* feat: impelemt DINO

* chore: delete debug code

* chore: impplement pre-commit

* fix: fix imported package

* chore: pre-commit check

* [CodeCamp2023-340] New Version of config Adapting MobileNet Algorithm (#1774)

* add new config adapting MobileNetV2,V3

* add base model config for mobile net v3, modified all training configs of mobile net v3 inherit from the base model config

* removed directory _base_/models/mobilenet_v3

* [Feature] Implement of Zero-Shot CLIP Classifier (#1737)

* zero-shot CLIP

* modify zero-shot clip config

* add in1k_sub_prompt(8 prompts) for improvement

* add some annotations doc

* clip base class & clip_zs sub-class

* some modifications of details after review

* convert into and use mmpretrain-vit

* modify names of some files and directories

* ram init commit

* [Fix] Fix pipeline bug in image retrieval inferencer

* [CodeCamp2023-341] 多模态数据集文档补充-COCO Retrieval

* Update OFA to compat with latest huggingface.

* Update train.py to compat with new config

* Bump version to v1.1.0

* Update __init__.py

---------

Co-authored-by: LALBJ <40877073+LALBJ@users.noreply.github.com>
Co-authored-by: DE009 <57087096+DE009@users.noreply.github.com>
Co-authored-by: mzr1996 <mzr1996@163.com>
Co-authored-by: 飞飞 <102729089+ASHORE1225@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants