Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support HRNet and add pre-trained models #660

Merged
merged 11 commits into from
Jan 28, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jan 18, 2022

Motivation

Support HRNet

Modification

As the title

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@mzr1996 mzr1996 requested a review from Ezra-Yu January 18, 2022 11:21
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #660 (7d73c58) into dev (dc456a0) will decrease coverage by 0.00%.
The diff coverage is 89.28%.

❗ Current head 7d73c58 differs from pull request most recent head 831a93c. Consider uploading reports for the commit 831a93c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #660      +/-   ##
==========================================
- Coverage   83.00%   83.00%   -0.01%     
==========================================
  Files         124      125       +1     
  Lines        7409     7512     +103     
  Branches     1289     1310      +21     
==========================================
+ Hits         6150     6235      +85     
- Misses       1077     1092      +15     
- Partials      182      185       +3     
Flag Coverage Δ
unittests 83.00% <89.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/hrnet.py 87.16% <87.16%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/backbones/resnet.py 100.00% <100.00%> (ø)
mmcls/models/necks/__init__.py 100.00% <100.00%> (ø)
mmcls/models/necks/hr_fuse.py 100.00% <100.00%> (ø)
mmcls/models/backbones/convnext.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc456a0...831a93c. Read the comment docs.

mmcls/models/necks/hr_fuse.py Outdated Show resolved Hide resolved
mmcls/models/necks/hr_fuse.py Outdated Show resolved Hide resolved
mmcls/models/backbones/hrnet.py Show resolved Hide resolved
configs/hrnet/README.md Outdated Show resolved Hide resolved
mmcls/models/backbones/hrnet.py Show resolved Hide resolved
mmcls/models/backbones/hrnet.py Show resolved Hide resolved
mmcls/models/backbones/hrnet.py Show resolved Hide resolved
@mzr1996 mzr1996 force-pushed the hrnet branch 2 times, most recently from e9f4e6a to 7d73c58 Compare January 27, 2022 10:58
@Ezra-Yu Ezra-Yu self-requested a review January 27, 2022 11:21
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 5de480e into open-mmlab:dev Jan 28, 2022
@mzr1996 mzr1996 mentioned this pull request Jan 29, 2022
27 tasks
Ezra-Yu pushed a commit to Ezra-Yu/mmclassification that referenced this pull request Feb 14, 2022
* Support HRNet

* Add HRNet configs

* Fix a bug in backward

* Add configs and update docs.

* Not use bias in conv before batch norm

* Defaults to use `norm_eval=False`

* Add unit tests and support out_channels in HRFuseScales

* Update checkpoint path

* Update docstring.

* Remove incorrect files

* Improve according to comments
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* Support HRNet

* Add HRNet configs

* Fix a bug in backward

* Add configs and update docs.

* Not use bias in conv before batch norm

* Defaults to use `norm_eval=False`

* Add unit tests and support out_channels in HRFuseScales

* Update checkpoint path

* Update docstring.

* Remove incorrect files

* Improve according to comments
@mzr1996 mzr1996 deleted the hrnet branch December 7, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants