Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ResNetV1c #692

Merged
merged 6 commits into from
Feb 23, 2022
Merged

[Feature] Add ResNetV1c #692

merged 6 commits into from
Feb 23, 2022

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Feb 14, 2022

Motivation

Add ResNetV1c

Modification

Add ResNetV1c

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #692 (72e557b) into dev (43024cd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #692   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files         121      121           
  Lines        7389     7393    +4     
  Branches     1277     1278    +1     
=======================================
+ Hits         6283     6287    +4     
  Misses        916      916           
  Partials      190      190           
Flag Coverage Δ
unittests 85.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/backbones/resnet.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43024cd...72e557b. Read the comment docs.

mmcls/models/backbones/resnet.py Outdated Show resolved Hide resolved
@Ezra-Yu Ezra-Yu requested a review from mzr1996 February 21, 2022 05:09
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 7fcaedc into open-mmlab:dev Feb 23, 2022
@Ezra-Yu Ezra-Yu mentioned this pull request Mar 3, 2022
27 tasks
@Ezra-Yu Ezra-Yu deleted the ResNetV1c branch July 18, 2022 08:47
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add ResNetV1c

* add unit tests

* fix lint

* update docstring

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants