Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ADD RepMLP Backbone and checkpoints #709

Merged
merged 18 commits into from
Mar 30, 2022
Merged

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Feb 23, 2022

Motivation

ADD RepMLP Backbone and checkpoints

Modification

ADD RepMLP Backbone and checkpoints

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #709 (1a07f96) into dev (995f291) will increase coverage by 0.30%.
The diff coverage is 97.20%.

❗ Current head 1a07f96 differs from pull request most recent head 4c27b23. Consider uploading reports for the commit 4c27b23 to get more accurate results

@@            Coverage Diff             @@
##              dev     #709      +/-   ##
==========================================
+ Coverage   85.11%   85.41%   +0.30%     
==========================================
  Files         124      125       +1     
  Lines        7690     7904     +214     
  Branches     1328     1362      +34     
==========================================
+ Hits         6545     6751     +206     
- Misses        951      953       +2     
- Partials      194      200       +6     
Flag Coverage Δ
unittests 85.34% <97.20%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/repmlp.py 97.14% <97.14%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/utils/se_layer.py 92.30% <100.00%> (+1.00%) ⬆️
mmcls/utils/setup_env.py 95.45% <0.00%> (-4.55%) ⬇️
mmcls/datasets/builder.py 89.55% <0.00%> (-1.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2921270...4c27b23. Read the comment docs.

@Ezra-Yu Ezra-Yu requested a review from mzr1996 February 23, 2022 06:27
@Ezra-Yu Ezra-Yu mentioned this pull request Mar 3, 2022
27 tasks
@mzr1996
Copy link
Member

mzr1996 commented Mar 23, 2022

Please fix conflict

@Ezra-Yu Ezra-Yu requested a review from mzr1996 March 30, 2022 05:17
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 922a31a into open-mmlab:dev Mar 30, 2022
@Ezra-Yu Ezra-Yu deleted the repmlp branch July 18, 2022 08:47
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add repmlp

* refactor backbone code

* add checkpoint, readme, unit tests

* unchange demo

* improve docstring.

* update pic

* refactor patch embed

* refactor unit tests

* fix lint

* update tools

* update tools

* Update checkpoint path

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants