Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add CSPNet and backbone and checkpoints #735

Merged
merged 12 commits into from
Mar 30, 2022

Conversation

Ezra-Yu
Copy link
Collaborator

@Ezra-Yu Ezra-Yu commented Mar 16, 2022

Motivation

Add CSPNet and backbone and checkpoints

Modification

Please briefly describe what modification is made in this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #735 (cc706bb) into dev (3482521) will increase coverage by 0.22%.
The diff coverage is 94.52%.

@@            Coverage Diff             @@
##              dev     #735      +/-   ##
==========================================
+ Coverage   85.03%   85.26%   +0.22%     
==========================================
  Files         123      125       +2     
  Lines        7604     7844     +240     
  Branches     1311     1356      +45     
==========================================
+ Hits         6466     6688     +222     
- Misses        946      957      +11     
- Partials      192      199       +7     
Flag Coverage Δ
unittests 85.17% <94.06%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/cspnet.py 92.81% <92.81%> (ø)
mmcls/models/backbones/convmixer.py 98.36% <98.36%> (ø)
mmcls/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmcls/models/backbones/resnet.py 100.00% <100.00%> (ø)
mmcls/datasets/builder.py 91.04% <0.00%> (ø)
mmcls/models/backbones/convnext.py 94.78% <0.00%> (ø)
mmcls/datasets/samplers/repeat_aug.py 90.90% <0.00%> (+0.43%) ⬆️
mmcls/datasets/samplers/distributed_sampler.py 85.18% <0.00%> (+1.18%) ⬆️
mmcls/datasets/dataset_wrappers.py 71.83% <0.00%> (+1.24%) ⬆️
mmcls/core/utils/dist_utils.py 32.07% <0.00%> (+8.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04cb42a...cc706bb. Read the comment docs.

@Ezra-Yu Ezra-Yu changed the base branch from master to dev March 23, 2022 07:40
@Ezra-Yu Ezra-Yu changed the title [WIP] Add CSPNet and backbone and checkpoints [Feature] Add CSPNet and backbone and checkpoints Mar 30, 2022
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzr1996 mzr1996 merged commit 2921270 into open-mmlab:dev Mar 30, 2022
@Ezra-Yu Ezra-Yu mentioned this pull request Apr 1, 2022
27 tasks
@Ezra-Yu Ezra-Yu deleted the cspnet branch July 18, 2022 08:47
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add cspnet backbone

* try

* add backbones

* add cspnet

* add acc

* add unit tests

* chnage mode

* Update checkpoint path

* Fix typo

* Imporve CSPNet

* Update checkpoints

Co-authored-by: mzr1996 <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants