Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Distiller v2 #107

Closed
wants to merge 33 commits into from
Closed

[WIP] Distiller v2 #107

wants to merge 33 commits into from

Conversation

pppppM
Copy link
Collaborator

@pppppM pppppM commented Mar 10, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@pppppM pppppM added the WIP label Mar 10, 2022
@pppppM pppppM self-assigned this Mar 10, 2022
@pppppM pppppM changed the base branch from master to dev_v0.3.0 March 10, 2022 09:39
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #107 (6af7327) into dev_v0.3.0 (81e0e34) will increase coverage by 1.45%.
The diff coverage is 35.18%.

@@              Coverage Diff               @@
##           dev_v0.3.0     #107      +/-   ##
==============================================
+ Coverage       58.46%   59.91%   +1.45%     
==============================================
  Files              87      107      +20     
  Lines            3154     3700     +546     
  Branches          581      660      +79     
==============================================
+ Hits             1844     2217     +373     
- Misses           1223     1375     +152     
- Partials           87      108      +21     
Flag Coverage Δ
unittests 59.91% <35.18%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrazor/models/distillers/base.py 40.57% <ø> (-1.68%) ⬇️
mmrazor/models/losses/rank_mimic.py 20.37% <20.37%> (ø)
mmrazor/models/distillers/single_teacher_v2.py 23.18% <23.18%> (ø)
mmrazor/core/delivers/function_outputs_deliver.py 29.62% <29.62%> (ø)
mmrazor/core/delivers/method_outputs_deliver.py 29.62% <29.62%> (ø)
mmrazor/core/recorders/recorder_manager.py 33.33% <33.33%> (ø)
...mrazor/core/recorders/function_outputs_recorder.py 34.48% <34.48%> (ø)
mmrazor/core/recorders/method_outputs_recorder.py 34.48% <34.48%> (ø)
mmrazor/core/recorders/module_inputs_recorder.py 34.78% <34.78%> (ø)
mmrazor/core/recorders/module_outputs_recorder.py 34.78% <34.78%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e0e34...6af7327. Read the comment docs.

@pppppM pppppM closed this Jan 3, 2023
humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
* add shape constantofshape unittest for ncnn

* fix lint

* standarize import

* fix lint

* reply for code review

* reply for code review

* fix lint

* remove some hardcode

* fix lint

* reply for code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant