Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #35 Support DIOR Dataset #639

Merged
merged 12 commits into from
Nov 30, 2022
Merged

Conversation

yxzhao2022
Copy link

@yxzhao2022 yxzhao2022 commented Nov 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support DIOR Dataset.
Complete task1 in #626

Modification

Implement the DIOR dataset and related documents.

Performance:

model backbone map angle lr schd
rotated retinanet resnet50 50.26 oc 1x
rotated retinanet resnet50 53.94 le90 1x

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 60.95% // Head: 79.68% // Increases project coverage by +18.72% 🎉

Coverage data is based on head (77699bb) compared to base (29636ee).
Patch coverage: 76.69% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x     #639       +/-   ##
============================================
+ Coverage    60.95%   79.68%   +18.72%     
============================================
  Files           95       96        +1     
  Lines         6460     6562      +102     
  Branches       915      932       +17     
============================================
+ Hits          3938     5229     +1291     
+ Misses        2315     1025     -1290     
- Partials       207      308      +101     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrotate/datasets/dior.py 76.23% <76.23%> (ø)
mmrotate/datasets/__init__.py 100.00% <100.00%> (ø)
mmrotate/evaluation/metrics/dota_metric.py 87.00% <0.00%> (-1.13%) ⬇️
mmrotate/models/task_modules/coders/angle_coder.py 44.55% <0.00%> (+1.98%) ⬆️
mmrotate/testing/_utils.py 83.62% <0.00%> (+5.17%) ⬆️
.../task_modules/assigners/rotate_iou2d_calculator.py 67.36% <0.00%> (+5.26%) ⬆️
mmrotate/models/dense_heads/rotated_fcos_head.py 68.85% <0.00%> (+6.55%) ⬆️
mmrotate/models/roi_heads/gv_ratio_roi_head.py 75.00% <0.00%> (+8.33%) ⬆️
...els/task_modules/coders/delta_xywht_hbbox_coder.py 99.13% <0.00%> (+17.24%) ⬆️
mmrotate/utils/misc.py 42.85% <0.00%> (+21.42%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tests/test_datasets/test_dior.py Outdated Show resolved Hide resolved
configs/_base_/datasets/dior.py Show resolved Hide resolved
mmrotate/datasets/dior.py Outdated Show resolved Hide resolved
zytx121
zytx121 previously approved these changes Nov 28, 2022
Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

liuyanyi
liuyanyi previously approved these changes Nov 28, 2022
Copy link
Collaborator

@liuyanyi liuyanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxzhao2022 yxzhao2022 dismissed stale reviews from liuyanyi and zytx121 via 77699bb November 29, 2022 13:25
@RangiLyu RangiLyu merged commit e8c6eb8 into open-mmlab:dev-1.x Nov 30, 2022
@zytx121 zytx121 changed the title [Feature] Support DIOR Dataset CodeCamp #35 Support DIOR Dataset Nov 30, 2022
@zytx121 zytx121 mentioned this pull request Dec 30, 2022
triple-Mu pushed a commit to triple-Mu/mmrotate that referenced this pull request Jan 31, 2023
* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* [Feature] Support DIOR Dataset

* Update test_dior.py

* Update dior.py

* Update README.md

* Update metafile.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants