Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add UNet benchmark with multiple losses supervision. #1143

Merged
merged 5 commits into from Dec 23, 2021

Conversation

MengzhangLI
Copy link
Contributor

@MengzhangLI MengzhangLI commented Dec 17, 2021

Motivation

To improve numerical results of UNet benchmark, using multiple losses (1.0 * cross entropy loss + 3.0 * dice loss) is introduced in this pr.

To testify representation ability of UNet on natural image, benchmark of UNet on Cityscapes dataset is also added in this pr.

Note

(1) For DRIVE, STARE, CHASE_DB1 and HRF, using multiple losses (dice vs cross entropy is 3:1).
(2) Add cityscapes benchmark.

  • Upload models & logs
  • Keep all models using CrossEntropyLoss only and using multiple losses with CrossEntropyLoss and DiceLoss.
  • Add mDice results of existing using CrossEntropyLoss only models.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1143 (9629eb5) into master (9975c67) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1143      +/-   ##
==========================================
- Coverage   90.11%   90.07%   -0.04%     
==========================================
  Files         125      125              
  Lines        7262     7268       +6     
  Branches     1206     1206              
==========================================
+ Hits         6544     6547       +3     
- Misses        515      518       +3     
  Partials      203      203              
Flag Coverage Δ
unittests 90.07% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/segmentors/base.py 57.85% <0.00%> (-1.48%) ⬇️
mmseg/datasets/custom.py 94.68% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9975c67...9629eb5. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Should rename the title to descript this PR in more detail.

@Junjun2016
Copy link
Collaborator

Should not override the previous results.
Key previous results and add new results.

@MengzhangLI MengzhangLI self-assigned this Dec 17, 2021
@MengzhangLI MengzhangLI added the WIP Work in process label Dec 21, 2021
@MengzhangLI MengzhangLI added the Merging PR waited for merging label Dec 22, 2021
@Junjun2016
Copy link
Collaborator

Should rename the title to descript this PR in more detail.

Should resolve this comment. :)

@MengzhangLI MengzhangLI changed the title [Feature] New Unet benchmark [Feature] New Unet Benchmark Using Multiple Losses. Dec 23, 2021
@Junjun2016 Junjun2016 changed the title [Feature] New Unet Benchmark Using Multiple Losses. [Feature] Add UNet Benchmark with Multiple Losses supervision. Dec 23, 2021
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config with multiple losses can inherit from the config with only CE loss.

@Junjun2016 Junjun2016 changed the title [Feature] Add UNet Benchmark with Multiple Losses supervision. [Feature] Add UNet benchmark with multiple losses supervision. Dec 23, 2021
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 merged commit 7f06e01 into open-mmlab:master Dec 23, 2021
@MengzhangLI MengzhangLI removed WIP Work in process Merging PR waited for merging labels Dec 25, 2021
@MengzhangLI MengzhangLI deleted the unet_benchmark branch February 1, 2022 03:19
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
…mlab#1143)

* upload models and new configs

* fix hrf readme error

* fix hrf readme error

* add mDice of old models

* refactor configs
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* add cam runner [wip]

* update webcam runner and node api

* reorganize module structure

* add model node

* add pose model node [wip]

* update message

* add monitor node

* rename config

* refactor webcam util

* add update_route_info

* add input_check_interval

* add fps for one-euro in mmpose node

* refactor visualition nodes

* fix bug

* modify runner argument and fix bug

* add doc

* add doc

* add webcam_runner docstrings

* add docstrings

* update interface and docstring

* add RecorderNode

* * add syncrhonous result binding mode
* refactor node event handler

* fix typing

* fix typing (open-mmlab#1082)

* * Add RecorderNode for saving video to files
* Add exiting handler method to nodes
* Add VideoEndingMessage

* rename _on_exit ot on_exit

* fix typing

* Fix a few issues

* register node event handler in __init__
* change default pose model to vipnas_mblv3
* Node._on_exit -> Node.on_exit

* fix typing

* fix typing

* change from thread based to process based

* solve cuda distributed [wip]

* fix process creating method and buffer size

* thread based buffer

* node based on thread

* node set daemon=False as default

* fix logging level and add docstrings

* modify register_event

* * reorganize webcam tool configs
* modify frame rate calculation
* rename BillboardNode as NoticeBoardNode

* [WebcamAPI] Add demo README (open-mmlab#1133)

* add README.md

* update gif

* [WebcamAPI] Add facwswap node and config (open-mmlab#1094)

* add facwswap node

* adapt to webcam_api

* adapt to webcam_api

* move config

* add sync mode in runner

* fix bugs and update nodes

* [WebcamAPI] Supersaiyan (open-mmlab#1098)

* add supersaiyan effects

* fix init

* apply background

* update config

* apply saiyan effects

* rebase

* rebase and fix

* update doc

* update docs

* add load image from disk or url

* make the resources to url links

* mv load_image_from_disk_or_url to utils/misc

* move effect funcs to webcam_api

* rebase

* fix pytest

* fix docs

* add get_local_path_given_url

* add get_local_path_given_url

* rename to get_cached_file_path

* update readme

* update readme

* fix bug that only one bbox is detected for each class

* fix faceswap config

* add newyear demo (open-mmlab#1143)

Co-authored-by: zengwang <zengwang430521@gmail.com>

* [Feature] Add a `SpriteNode` for Webcam API (open-mmlab#1160)

* Fix missing flag in `load_image_from_disk_or_url`

* Add SpriteNode

* Meow dwen dwen (open-mmlab#1173)

* fix mmpose nodes

* add dummy video capture

* add xdwendwen node

* fix configs

* Update README.md

* [WebcamAPI] Update XDwenDwen example (open-mmlab#1177)

* Update XDwenDwen example

* add rigid transform
* update configs and readme files

* extend meow dwen dwen

* update config

* support cfg-options

* turn-off default help instruction

* fix typo

Co-authored-by: Jas <jinsheng@sensetime.com>
Co-authored-by: Lumin <30328525+luminxu@users.noreply.github.com>
Co-authored-by: zengwang <zengwang430521@gmail.com>
Co-authored-by: Ma Zerun <mzr1996@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants