Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update correct In Collection in metafile of each configs. #1239

Merged
merged 16 commits into from
Feb 23, 2022

Conversation

MengzhangLI
Copy link
Contributor

Motivation

Use correct In Collection names of each method, especially In Collection and backbone of Metadata should be different.

This pr would be merged after PR #1233 because they all modify md2yml file.

Related PR:
MMDetection3D: open-mmlab/mmdetection3d#1184.

@MengzhangLI MengzhangLI self-assigned this Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1239 (a88d9af) into master (4f4e772) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         131      131           
  Lines        7599     7599           
  Branches     1264     1264           
=======================================
  Hits         6858     6858           
  Misses        531      531           
  Partials      210      210           
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c201b...a88d9af. Read the comment docs.

configs/twins/twins.yml Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
configs/twins/twins.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values of In Collection don't match the collection names

@@ -1,5 +1,5 @@
Collections:
- Name: erfnet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on my limited knowledge, erfnet might be an algorithm not backbone

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently delete Collections dict in some backbone readme such as HRNet, Swin Transformer and so on because they may be supported in MMClassification. Other methods which is algorithm rather than backbones all keep Collections dict but the Collection['Name'] and Models['In Collection'] are the same value.

configs/fcn/fcn.yml Outdated Show resolved Hide resolved
configs/icnet/icnet.yml Outdated Show resolved Hide resolved
configs/unet/unet.yml Outdated Show resolved Hide resolved
@MeowZheng MeowZheng merged commit 8cf333c into open-mmlab:master Feb 23, 2022
@MengzhangLI MengzhangLI deleted the check_backbone_collections branch February 28, 2022 12:31
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…en-mmlab#1239)

* change md2yml file

* update metafile

* update twins In Collection automatically

* fix twins metafile

* fix twins metafile

* all metafile use value of Method

* update collect name

* update collect name

* fix some typo

* fix FCN D6

* change JPU to FastFCN

* fix some typos in DNLNet, NonLocalNet, SETR, Segmenter, STDC, FastSCNN

* fix typo in stdc

* fix typo in DNLNet and UNet

* fix NonLocalNet typo
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants