Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Upgrade isort in pre-commit hook #1270

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

MengzhangLI
Copy link
Contributor

Related PR: open-mmlab/mmflow#87.

  1. Remove seed-isort-config in pre-commit hook
  2. Upgrade isort to v5.10.1 (latest version)
  3. Replace known_standard_library with extra_standard_library

Note: Due to isort upgradation, some .py files would automatically modified by new isort package.

@MengzhangLI MengzhangLI self-assigned this Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1270 (b8ec9e0) into master (29cfcd1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1270   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files         130      130           
  Lines        7553     7553           
  Branches     1257     1257           
=======================================
  Hits         6818     6818           
  Misses        528      528           
  Partials      207      207           
Flag Coverage Δ
unittests 90.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/builder.py 87.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af88b86...b8ec9e0. Read the comment docs.

@MeowZheng MeowZheng merged commit b4314f9 into open-mmlab:master Feb 8, 2022
@MengzhangLI MengzhangLI deleted the isort-upgrade branch February 16, 2022 11:11
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Older versions of xformers require query, key, value to be contiguous, this calls .contiguous() on q/k/v before passing to xformers.
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* 'inference_for_voxelpose'

* 'fix_bug'

* 'readme'

* fix lint

* add auto downlaod

* 'unit_test'

* 'load_camera_params_from_downloaded_data'

* 'add_torch_no_grad'

* 'unit_test_show_results'

* 'vis_2d_in_unit_test'

* 'fix_typo'

* fix lint

Co-authored-by: wusize <wusize@sensetime.com>
Co-authored-by: ly015 <liyining0712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants