Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define blood vessel dataset and fix filename bug #203

Merged
merged 5 commits into from Oct 23, 2020
Merged

Define blood vessel dataset and fix filename bug #203

merged 5 commits into from Oct 23, 2020

Conversation

yamengxi
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


yamengxi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -37,4 +37,4 @@ repos:
rev: v1.3.1
hooks:
- id: docformatter
args: ["--in-place", "--wrap-descriptions", "79"]
args: ["--in-place", "--wrap-descriptions", "79"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't modify any code here.

@hellock
Copy link
Member

hellock commented Oct 21, 2020

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #203 into master will increase coverage by 0.42%.
The diff coverage is 92.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   83.20%   83.62%   +0.42%     
==========================================
  Files          83       89       +6     
  Lines        3924     4105     +181     
  Branches      619      647      +28     
==========================================
+ Hits         3265     3433     +168     
- Misses        522      533      +11     
- Partials      137      139       +2     
Flag Coverage Δ
#unittests 83.62% <92.81%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/chase_db1.py 80.00% <80.00%> (ø)
mmseg/datasets/drive.py 80.00% <80.00%> (ø)
mmseg/datasets/hrf.py 80.00% <80.00%> (ø)
mmseg/datasets/stare.py 80.00% <80.00%> (ø)
mmseg/models/backbones/unet.py 95.76% <95.76%> (ø)
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmseg/models/utils/__init__.py 100.00% <100.00%> (ø)
mmseg/models/utils/up_conv_block.py 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2e0d3...b235208. Read the comment docs.



@DATASETS.register_module()
class DriveDataset(CustomDataset):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class DriveDataset(CustomDataset):
class DRIVEDataset(CustomDataset):



@DATASETS.register_module()
class HrfDataset(CustomDataset):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class HrfDataset(CustomDataset):
class HRFDataset(CustomDataset):



@DATASETS.register_module()
class StareDataset(CustomDataset):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class StareDataset(CustomDataset):
class STAREDataset(CustomDataset):



@DATASETS.register_module()
class Chase_db1Dataset(CustomDataset):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class Chase_db1Dataset(CustomDataset):
class ChaseDB1Dataset(CustomDataset):

@yamengxi
Copy link
Collaborator Author

Waiting for review!

@xvjiarui xvjiarui merged commit 3bdc276 into open-mmlab:master Oct 23, 2020
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* fix filename bug

* define blood vessel dataset

* redo debug

* fix small bug

* rename dataset

Co-authored-by: yamengxi <yamengxi@sensetime.com>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* Revive Make utils

* Add datasets for training too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants