Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix binary segmentation #2101

Merged
merged 6 commits into from Sep 27, 2022
Merged

Conversation

xiexinch
Copy link
Collaborator

Motivation

As #2016

Modification

  1. Add threshold and out_channels parameters to decode_head
  2. Fix inference logits while num_classes==1

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 83.13% // Head: 83.67% // Increases project coverage by +0.53% 🎉

Coverage data is based on head (4aaa1b9) compared to base (2a18328).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2101      +/-   ##
===========================================
+ Coverage    83.13%   83.67%   +0.53%     
===========================================
  Files          138      138              
  Lines         7780     7790      +10     
  Branches      1246     1252       +6     
===========================================
+ Hits          6468     6518      +50     
+ Misses        1128     1094      -34     
+ Partials       184      178       -6     
Flag Coverage Δ
unittests 83.67% <100.00%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/decode_head.py 93.85% <100.00%> (+6.60%) ⬆️
mmseg/models/segmentors/base.py 87.30% <100.00%> (-0.58%) ⬇️
mmseg/models/segmentors/encoder_decoder.py 90.08% <100.00%> (+28.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch xiexinch changed the title [WIP][Fix] Fix binary segmentation [Fix] Fix binary segmentation Sep 27, 2022
@MeowZheng MeowZheng merged commit b3b7629 into open-mmlab:dev-1.x Sep 27, 2022
MeowZheng pushed a commit to MeowZheng/mmsegmentation that referenced this pull request Nov 1, 2022
* add out_channels

* fix forward

* add decode_head ut

* add segmentor ut

* refine postprocess

* fix
@MeowZheng MeowZheng added the 1.x Related issue of 1.x version label Nov 1, 2022
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
* add out_channels

* fix forward

* add decode_head ut

* add segmentor ut

* refine postprocess

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Related issue of 1.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants