[Feature] Support MMSegInferencer #2413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.29% // Head: 83.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2413 +/- ##
===========================================
+ Coverage 83.29% 83.52% +0.23%
===========================================
Files 146 147 +1
Lines 8522 8620 +98
Branches 1275 1293 +18
===========================================
+ Hits 7098 7200 +102
+ Misses 1212 1195 -17
- Partials 212 225 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MeowZheng
force-pushed
the
dev-1.x
branch
3 times, most recently
from
4c28e1e
to
115552d
Compare
xiexinch
force-pushed
the
mmseg_inferencer
branch
from
d974015
to
00546a5
Compare
xiexinch
force-pushed
the
mmseg_inferencer
branch
from
00546a5
to
fd79dcd
Compare
MeowZheng
reviewed
Feb 1, 2023
mmseg/apis/mmseg_inferencer.py
Outdated
| wait_time: int = 0, | ||
| draw_pred: bool = True, | ||
| out_dir: str = '', | ||
| print_result: bool = False, |
There was a problem hiding this comment.
print_result might be not suit for segmentation task?
mmseg/apis/mmseg_inferencer.py
Outdated
Comment on lines
91
to
110
| def visualize(self, | ||
| inputs: list, | ||
| preds: List[dict], | ||
| return_vis: bool = False, | ||
| show: bool = False, | ||
| wait_time: int = 0, | ||
| draw_pred: bool = True, | ||
| img_out_dir: str = '', | ||
| opacity: float = 0.8) -> List[np.ndarray]: | ||
| """Visualize predictions. | ||
|
|
||
| Args: | ||
| inputs (list): Inputs preprocessed by :meth:`_inputs_to_list`. | ||
| preds (Any): Predictions of the model. | ||
| show (bool): Whether to display the image in a popup window. | ||
| Defaults to False. | ||
|
|
||
| Returns: | ||
| List[np.ndarray]: Visualization results. | ||
| """ |
There was a problem hiding this comment.
please add docstring for this kwargs
mmseg/apis/mmseg_inferencer.py
Outdated
| def visualize(self, | ||
| inputs: list, | ||
| preds: List[dict], | ||
| return_vis: bool = False, |
There was a problem hiding this comment.
I think return_vis might not work?
MeowZheng
reviewed
Feb 22, 2023
tests/test_apis/test_inferencer.py
Outdated
| infer = MMSegInferencer(cfg, ckpt_filename) | ||
|
|
||
| # test forward | ||
| img = np.random.randint(0, 256, (4, 4, 3)).astype(np.float32) |
There was a problem hiding this comment.
why the input data type is np.float32?
MeowZheng
reviewed
Feb 23, 2023
mmseg/apis/mmseg_inferencer.py
Outdated
Comment on lines
21
to
22
| """MMSegInferencer. | ||
|
|
There was a problem hiding this comment.
might add MMSegInferencer needs mmengine>=0.5.0 in docstring
MeowZheng
approved these changes
Feb 23, 2023
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
## Motivation Support `MMSegInferencer` for providing an easy and clean interface for single or multiple images inferencing. Ref: open-mmlab/mmengine#773 open-mmlab/mmocr#1608 ## Modification - mmseg/apis/mmseg_inferencer.py - mmseg/visualization/local_visualizer.py - demo/image_demo_with_inferencer.py ## Use cases (Optional) Based on https://github.com/open-mmlab/mmengine/tree/inference Add a new image inference demo with `MMSegInferencer` - demo/image_demo_with_inferencer.py ```shell python demo/image_demo_with_inferencer.py demo/demo.png fcn_r50-d8_4xb2-40k_cityscapes-512x1024 ``` --------- Co-authored-by: MeowZheng <meowzheng@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support
MMSegInferencerfor providing an easy and clean interface for single or multiple images inferencing.Ref: open-mmlab/mmengine#773 open-mmlab/mmocr#1608
Modification
Use cases (Optional)
Based on https://github.com/open-mmlab/mmengine/tree/inference
Add a new image inference demo with
MMSegInferencer