Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeCamp #140 [New] [Feature] Add synapse dataset and data augmentation in dev-1.x. #2432

Merged
merged 41 commits into from
Jan 6, 2023
Merged

Conversation

Dominic23331
Copy link
Contributor

@Dominic23331 Dominic23331 commented Dec 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Synapse dataset in MMSegmentation.
Old PR: #2372.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

BLUE-coconut and others added 30 commits November 30, 2022 20:18
CodeCamp #144 [Doc] Chinese version of config tutorial
Co-authored-by: 谢昕辰 <xiexinch@outlook.com>
CodeCamp #147 [Doc] Add Chinese version of train & test tutorial
Co-authored-by: 谢昕辰 <xiexinch@outlook.com>
Co-authored-by: 谢昕辰 <xiexinch@outlook.com>
CodeCamp #1562 [Doc] Add Chinese version of `overview.md`
[Doc] Add ZN datasets.md in dev-1.x
MeowZheng and others added 4 commits December 20, 2022 12:38
CodeCamp #1565 [Doc] update the Chinese version of `get_started.md`
[Projects] Add 'Projects/' folder, and the first example project
@MengzhangLI MengzhangLI assigned MengzhangLI and unassigned xiexinch Dec 23, 2022
@MengzhangLI MengzhangLI changed the title synapse CodeCamp #140 [New] [Feature] Add synapse dataset and data augmentation in dev-1.x. Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 83.41% // Head: 83.44% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b062e9c) compared to base (6af2b8e).
Patch coverage: 90.19% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2432      +/-   ##
===========================================
+ Coverage    83.41%   83.44%   +0.02%     
===========================================
  Files          144      145       +1     
  Lines         8375     8426      +51     
  Branches      1249     1257       +8     
===========================================
+ Hits          6986     7031      +45     
- Misses        1183     1189       +6     
  Partials       206      206              
Flag Coverage Δ
unittests 83.44% <90.19%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmseg/utils/__init__.py 100.00% <ø> (ø)
mmseg/utils/class_names.py 83.82% <50.00%> (-2.12%) ⬇️
mmseg/datasets/transforms/transforms.py 90.95% <92.30%> (-0.07%) ⬇️
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/datasets/synapse.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng force-pushed the dev-1.x branch 4 times, most recently from 4c28e1e to 115552d Compare December 30, 2022 14:56
@MengzhangLI MengzhangLI added High Priority from Community This issue/pr needs more attention and higher priority than default developing plan Dataset Improvement or addition of new dataset 1.x Related issue of 1.x version medical WIP Work in process labels Dec 31, 2022
@MengzhangLI
Copy link
Contributor

LGTM

P.S: The dataset has been checked with PR author and it is the same as TransUNet data input.

@MengzhangLI MengzhangLI removed the WIP Work in process label Jan 6, 2023
@MeowZheng MeowZheng merged commit 2d67e51 into open-mmlab:dev-1.x Jan 6, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…augmentation in dev-1.x. (open-mmlab#2432)

## Motivation

Add Synapse dataset in MMSegmentation.
Old PR: open-mmlab#2372.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Related issue of 1.x version Dataset Improvement or addition of new dataset High Priority from Community This issue/pr needs more attention and higher priority than default developing plan medical
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants