[Fix] Remove dependcy mmdet when do not use MaskFormerHead and MMDET_Mask2FormerHead
#2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeowZheng
changed the title
MaskFormerHead and MMDET_Mask2FormerHead
Codecov ReportBase: 83.33% // Head: 83.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2448 +/- ##
===========================================
+ Coverage 83.33% 83.46% +0.12%
===========================================
Files 143 144 +1
Lines 8127 8238 +111
Branches 1211 1226 +15
===========================================
+ Hits 6773 6876 +103
- Misses 1165 1170 +5
- Partials 189 192 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* Adding support for `safetensors` and LoRa. * Adding metadata.
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* Fix regression introduced in open-mmlab#2448 * Style.
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
…ET_Mask2FormerHead` (open-mmlab#2448) ## Motivation Calling `mmseg.utils.register_all_modules` will import `MaskFormerHead` and `Mask2FormerHead`, it will crash if mmdet is not installed as `None` cannot be initialized. ## Modification - Modify `MMDET_MaskFormerHead=BaseModule` and `MMDET_Mask2FormerHead = BaseModule` when cannot import from mmdet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Calling
mmseg.utils.register_all_moduleswill importMaskFormerHeadandMask2FormerHead, it will crash if mmdet is not installed asNonecannot be initialized.Modification
MMDET_MaskFormerHead=BaseModuleandMMDET_Mask2FormerHead = BaseModulewhen cannot import from mmdet