Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add gt_edge_map field. #2466

Merged
merged 4 commits into from Jan 11, 2023

Conversation

274869388
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation of this PR is to add gt_edge_map field to support boundary loss.

Modification

  • GenerateEdge
    Modify gt_edge field to gt_edge_map.

  • PackSegInputs
    Add gt_edge_map to data_sample.

  • stack_batch
    Pad gt_edge_map to max_shape.

BC-breaking (Optional)

No

Use cases (Optional)

Reference GenerateEdge.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 83.44% // Head: 83.38% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (c595974) compared to base (f90f7a5).
Patch coverage: 12.50% of modified lines in pull request are covered.

❗ Current head c595974 differs from pull request most recent head c1c00bf. Consider uploading reports for the commit c1c00bf to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2466      +/-   ##
===========================================
- Coverage    83.44%   83.38%   -0.06%     
===========================================
  Files          145      145              
  Lines         8425     8432       +7     
  Branches      1257     1259       +2     
===========================================
+ Hits          7030     7031       +1     
- Misses        1189     1193       +4     
- Partials       206      208       +2     
Flag Coverage Δ
unittests 83.38% <12.50%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/formatting.py 88.88% <0.00%> (-8.09%) ⬇️
mmseg/utils/misc.py 87.50% <0.00%> (-7.96%) ⬇️
mmseg/datasets/transforms/transforms.py 91.08% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit 8dae946 into open-mmlab:dev-1.x Jan 11, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
## Motivation

The motivation of this PR is to add `gt_edge_map` field to support
boundary loss.

## Modification

- GenerateEdge
Modify `gt_edge` field to `gt_edge_map`.

- PackSegInputs
Add `gt_edge_map` to data_sample.

- stack_batch
Pad `gt_edge_map` to max_shape.

## BC-breaking (Optional)

No

## Use cases (Optional)

Reference `GenerateEdge`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants