Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix incorrect img_shape value assignment in RandomCrop #2469

Merged
merged 2 commits into from Jan 10, 2023

Conversation

xiexinch
Copy link
Collaborator

Motivation

Fix incorrect img_shape value assignment.

Modification

  • mmseg/datasets/transforms/transforms.py

@xiexinch xiexinch changed the title [Fix] Fix results[] [Fix] Fix incorrect img_shape value assignment in RandomCrop Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 83.44% // Head: 83.35% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (9fd0f12) compared to base (4e759bb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9fd0f12 differs from pull request most recent head 45658f4. Consider uploading reports for the commit 45658f4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2469      +/-   ##
===========================================
- Coverage    83.44%   83.35%   -0.09%     
===========================================
  Files          145      145              
  Lines         8426     8425       -1     
  Branches      1257     1257              
===========================================
- Hits          7031     7023       -8     
- Misses        1189     1199      +10     
+ Partials       206      203       -3     
Flag Coverage Δ
unittests 83.35% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/transforms/transforms.py 89.97% <100.00%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MeowZheng MeowZheng merged commit f90f7a5 into open-mmlab:dev-1.x Jan 10, 2023
@xiexinch xiexinch deleted the fix_random_crop branch January 10, 2023 10:43
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…mmlab#2469)

## Motivation

Fix incorrect `img_shape` value assignment.

## Modification

- mmseg/datasets/transforms/transforms.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants