[Fix] Switch order of reduce_zero_label and applying label_map in 1.x
#2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddancha
changed the title
reduce_zero_label and applying label_map in 1.x
MeowZheng
approved these changes
Jan 29, 2023
MengzhangLI
approved these changes
Jan 29, 2023
|
we have fixed ci problem in #2519 and please rebase this modification on it |
…l-map-reduce-zero-order-1.x
|
Great! Merged the latest version of |
Codecov ReportBase: 83.39% // Head: 83.40% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2517 +/- ##
===========================================
+ Coverage 83.39% 83.40% +0.01%
===========================================
Files 145 145
Lines 8510 8510
Branches 1274 1274
===========================================
+ Hits 7097 7098 +1
+ Misses 1198 1197 -1
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Merged
aravind-h-v
pushed a commit
to aravind-h-v/mmsegmentation
that referenced
this pull request
Mar 27, 2023
* Sequential cpu offload: require accelerate 0.14.0. * Import is_accelerate_version * Missing copy.
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
… 1.x (open-mmlab#2517) This is an almost exact duplicate of open-mmlab#2500 (that was made to the `master` branch) now applied to the `1.x` branch. --- ## Motivation I want to fix a bug through this PR. The bug occurs when two options -- `reduce_zero_label=True`, and custom classes are used. `reduce_zero_label` remaps the GT seg labels by remapping the zero-class to 255 which is ignored. Conceptually, this should occur *before* the `label_map` is applied, which maps *already reduced labels*. However, currently, the `label_map` is applied before the zero label is reduced. ## Modification The modification is simple: - I've just interchanged the order of the two operations by moving a few lines from bottom to top. - I've added a test that passes when the fix is introduced, and fails on the original `master` branch. ## BC-breaking (Optional) I do not anticipate this change braking any backward-compatibility. ## Checklist - [x] Pre-commit or other linting tools are used to fix the potential lint issues. - _I've fixed all linting/pre-commit errors._ - [x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness. - _I've added a unit test._ - [x] If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D. - _I don't think this change affects MMDet or MMDet3D._ - [x] The documentation has been modified accordingly, like docstring or example tutorials. - _This change fixes an existing bug and doesn't require modifying any documentation/docstring._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an almost exact duplicate of #2500 (that was made to the
masterbranch) now applied to the1.xbranch.Motivation
I want to fix a bug through this PR. The bug occurs when two options --
reduce_zero_label=True, and custom classes are used.reduce_zero_labelremaps the GT seg labels by remapping the zero-class to 255 which is ignored. Conceptually, this should occur before thelabel_mapis applied, which maps already reduced labels. However, currently, thelabel_mapis applied before the zero label is reduced.Modification
The modification is simple:
masterbranch.BC-breaking (Optional)
I do not anticipate this change braking any backward-compatibility.
Checklist