Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Add Mapillary Vistas Datasets to MMSeg Core Package. #2576

Conversation

AI-Tianlong
Copy link
Contributor

@AI-Tianlong AI-Tianlong commented Feb 9, 2023

[Datasets] Add Mapillary Vistas Datasets to MMSeg Core Package .

Motivation

Add Mapillary Vistas Datasets to core package.
Old PR #2484

Modification

  • Add Mapillary Vistas Datasets to core package.
  • Delete tools/datasets_convert/mapillary.py , dataset does't need converting.
  • Add schedule_240k.py config.
  • Add configs files.
    deeplabv3plus_r101-d8_4xb2-240k_mapillay_v1-512x1024.py
    deeplabv3plus_r101-d8_4xb2-240k_mapillay_v2-512x1024.py
    maskformer_swin-s_4xb2-240k_mapillary_v1-512x1024.py
    maskformer_swin-s_4xb2-240k_mapillary_v2-512x1024.py
    maskformer_r101-d8_4xb2-240k_mapillary_v1-512x1024.py
    maskformer_r101-d8_4xb2-240k_mapillary_v2-512x1024.py
    pspnet_r101-d8_4xb2-240k_mapillay_v1-512x1024.py
    pspnet_r101-d8_4xb2-240k_mapillay_v2-512x1024.py
    
  • Synchronized changes to projects/mapillary_datasets

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if 240000 iters with SGD and 0.01 lr is a common setting, it should be add in _base_.

Moreover, please do not forget to add results in README and metafile.

docs/zh_cn/user_guides/2_dataset_prepare.md Outdated Show resolved Hide resolved
mmseg/datasets/mapillary.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Patch coverage: 74.07% and project coverage change: +0.01 🎉

Comparison is base (45fae72) 83.46% compared to head (617394a) 83.48%.

❗ Current head 617394a differs from pull request most recent head 7751b78. Consider uploading reports for the commit 7751b78 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2576      +/-   ##
===========================================
+ Coverage    83.46%   83.48%   +0.01%     
===========================================
  Files          147      148       +1     
  Lines         8669     8695      +26     
  Branches      1303     1306       +3     
===========================================
+ Hits          7236     7259      +23     
- Misses        1203     1205       +2     
- Partials       230      231       +1     
Flag Coverage Δ
unittests 83.48% <74.07%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/dataset_wrappers.py 49.18% <0.00%> (ø)
mmseg/datasets/transforms/transforms.py 90.53% <0.00%> (ø)
mmseg/datasets/transforms/formatting.py 86.36% <66.66%> (-3.38%) ⬇️
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/datasets/mapillary.py 91.66% <100.00%> (ø)
mmseg/utils/class_names.py 85.52% <100.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@serser
Copy link

serser commented Feb 25, 2023

It seems blocked, CI Started 11d 15h 10m 46s ago?

@AI-Tianlong AI-Tianlong changed the title [Datasets] Add Mapillary Vistas Datasets to MMSeg Core Package and Improve labels convert speed. [Datasets] Add Mapillary Vistas Datasets to MMSeg Core Package. Mar 9, 2023
Copy link
Collaborator

@xiexinch xiexinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would continue to add other models.

@MeowZheng MeowZheng merged commit 8c89ff3 into open-mmlab:dev-1.x Mar 15, 2023
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
)

* 📝 add textual inversion examples to docs

* 🖍 apply feedback

* 🖍 add colab link
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…-mmlab#2576)

## [Datasets] Add Mapillary Vistas Datasets to MMSeg Core Package .
## Motivation
Add Mapillary Vistas Datasets to core package.
Old PR open-mmlab#2484 

## Modification
- Add Mapillary Vistas Datasets to core package.
- Delete `tools/datasets_convert/mapillary.py` , dataset does't need
converting.
- Add `schedule_240k.py`  config.
- Add configs files.  
  ```none
  deeplabv3plus_r101-d8_4xb2-240k_mapillay_v1-512x1024.py
  deeplabv3plus_r101-d8_4xb2-240k_mapillay_v2-512x1024.py
  maskformer_swin-s_4xb2-240k_mapillary_v1-512x1024.py
  maskformer_swin-s_4xb2-240k_mapillary_v2-512x1024.py
  maskformer_r101-d8_4xb2-240k_mapillary_v1-512x1024.py
  maskformer_r101-d8_4xb2-240k_mapillary_v2-512x1024.py
  pspnet_r101-d8_4xb2-240k_mapillay_v1-512x1024.py
  pspnet_r101-d8_4xb2-240k_mapillay_v2-512x1024.py
  ```
- Synchronized changes to `projects/mapillary_datasets`

---------

Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
Co-authored-by: xiexinch <xiexinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants