Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] add Vampire dataset project in dev-1.x #2633

Merged
merged 15 commits into from May 6, 2023

Conversation

Provable0816
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

path = 'path/to/vampire'

if not os.path.exists(os.path.join(path, 'images', 'train')):
os.mkdirs(os.path.join(path, 'images', 'train'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os.mkdirs(os.path.join(path, 'images', 'train'))
os.system(f'mkdir -p {os.path.join(path, "images", "train")}')

os.mkdirs(os.path.join(path, 'images', 'train'))

if not os.path.exists(os.path.join(path, 'masks', 'train')):
os.mkdirs(os.path.join(path, 'masks', 'train'))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os.mkdirs(os.path.join(path, 'masks', 'train'))
os.system(f'mkdir -p {os.path.join(path, "masks", "train")}')

Comment on lines 23 to 25
shutil.copy(
os.path.join(origin_data_path, 'AMD14-GT', img),
os.path.join(path, 'masks', 'train', img))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shutil.copy(
os.path.join(origin_data_path, 'AMD14-GT', img),
os.path.join(path, 'masks', 'train', img))
# copy GT
img_gt = img.replace('.png', '-GT.png')
shutil.copy(
os.path.join(origin_data_path, 'AMD14-GT', f'{img_gt}'),
os.path.join(path, 'masks', 'train', img))

Comment on lines 31 to 33
shutil.copy(
os.path.join(origin_data_path, 'GER7-GT', img),
os.path.join(path, 'masks', 'train', img))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shutil.copy(
os.path.join(origin_data_path, 'GER7-GT', img),
os.path.join(path, 'masks', 'train', img))
# copy GT
img_gt = img.replace('.bmp', '-GT.png')
img = img.replace('bmp', 'png')
shutil.copy(
os.path.join(origin_data_path, 'GER7-GT', img_gt),
os.path.join(path, 'masks', 'train', img))

imgs = os.listdir(os.path.join(path, 'images', 'train'))
for img in imgs:
if not img.endswith('.png'):
im = Image.open(os.path.join(origin_data_path, 'images', 'train', img))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
im = Image.open(os.path.join(origin_data_path, 'images', 'train', img))
im = Image.open(os.path.join(path, 'images', 'train', img))

@@ -0,0 +1,42 @@
dataset_type = 'VampireDataset'
data_root = 'data/vampire'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data_root = 'data/vampire'
data_root = 'data'

@xiexinch xiexinch merged commit 77836e6 into open-mmlab:dev-1.x May 6, 2023
11 checks passed
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants