Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] add Ravir dataset project in dev-1.x #2635

Merged
merged 13 commits into from May 23, 2023

Conversation

Provable0816
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Comment on lines 10 to 19
imgs = glob.glob(os.path.join('./masks/train', '*.png'))

for im_path in tqdm(imgs):
im = Image.open(im_path)
imn = np.array(im)
imn[imn == 255] = 2
imn[imn == 128] = 1
imn[imn == 0] = 0
new_im = Image.fromarray(imn)
new_im.save(im_path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the directory structure, I don't think this script will work well. Could you update it?

$ tree data/RAVIR\ Dataset -L 2
data/RAVIR\ Dataset
├── test
│   ├── IR_Case_006.png
│   ├── IR_Case_024.png
│   ├── IR_Case_025.png
│   ├── IR_Case_028.png
│   ├── IR_Case_030.png
│   ├── IR_Case_031.png
│   ├── IR_Case_032.png
│   ├── IR_Case_033.png
│   ├── IR_Case_037.png
│   ├── IR_Case_042.png
│   ├── IR_Case_045.png
│   ├── IR_Case_046.png
│   ├── IR_Case_047.png
│   ├── IR_Case_048.png
│   ├── IR_Case_050.png
│   ├── IR_Case_054.png
│   ├── IR_Case_057.png
│   ├── IR_Case_059.png
│   └── IR_Case_060.png
└── train
    ├── training_images
    └── training_masks

Comment on lines 65 to 67
- download dataset from [here](https://ravir.grand-challenge.org/) and decompression data to path `'data/'`.
- run script `"python tools/prepare_dataset.py"` to split dataset and change folder structure as below.
- run script `"python ../../tools/split_seg_dataset.py"` to split dataset and generate `train.txt`, `val.txt` and `test.txt`. If the label of official validation set and test set can't be obtained, we generate `train.txt` and `val.txt` from the training set randomly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might update these steps and it's better to list the original directory structure.

@xiexinch xiexinch merged commit a9e960c into open-mmlab:dev-1.x May 23, 2023
3 of 7 checks passed
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants