Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add faq in dev-1.x branch #2765

Merged
merged 10 commits into from
Apr 3, 2023

Conversation

Renzhihan
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

@MeowZheng
Copy link
Collaborator

The faq is in docs/en/notes/faq.md for mmseg 1.x, and I think it is not necessary to add the version dependency of mmseg 0.x

@Renzhihan
Copy link
Contributor Author

The faq is in docs/en/notes/faq.md for mmseg 1.x, and I think it is not necessary to add the version dependency of mmseg 0.x

Thanks for your reply, I made a mistake in understanding the task. I will update the docs/en/notes/faq.md later.

Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow #2768 to add the version dependency of 1.x

@Renzhihan
Copy link
Contributor Author

I follow #2769 to delete the "Why is the log file not created" and other version errors.

docs/en/notes/faq.md Outdated Show resolved Hide resolved
docs/en/notes/faq.md Outdated Show resolved Hide resolved
docs/en/notes/faq.md Outdated Show resolved Hide resolved
@csatsurnh csatsurnh requested a review from xiexinch April 3, 2023 09:41
@xiexinch xiexinch merged commit 225e158 into open-mmlab:dev-1.x Apr 3, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants