Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] huasdorff distance loss #2820

Merged
merged 7 commits into from
Jun 19, 2023
Merged

[Feature] huasdorff distance loss #2820

merged 7 commits into from
Jun 19, 2023

Conversation

jinxianwei
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add Huasdorff distance loss

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 26.98% and project coverage change: -0.34 ⚠️

Comparison is base (892f9e1) 83.66% compared to head (e5b93d9) 83.32%.

❗ Current head e5b93d9 differs from pull request most recent head da644e3. Consider uploading reports for the commit da644e3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2820      +/-   ##
===========================================
- Coverage    83.66%   83.32%   -0.34%     
===========================================
  Files          156      157       +1     
  Lines         9355     9418      +63     
  Branches      1373     1381       +8     
===========================================
+ Hits          7827     7848      +21     
- Misses        1283     1325      +42     
  Partials       245      245              
Flag Coverage Δ
unittests 83.32% <26.98%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/losses/huasdorff_distance_loss.py 25.80% <25.80%> (ø)
mmseg/models/losses/__init__.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@xiexinch xiexinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add some unit tests.

mmseg/models/losses/huasdorff_distance_loss.py Outdated Show resolved Hide resolved
mmseg/models/losses/huasdorff_distance_loss.py Outdated Show resolved Hide resolved
@vansin
Copy link
Collaborator

vansin commented Jun 8, 2023

@jinxianwei can refer to this document for writing unit tests (https://mmsig.openmmlab.com/general/unitest).

@xiexinch xiexinch changed the title huasdorff distance loss [Feature] huasdorff distance loss Jun 16, 2023
@xiexinch xiexinch merged commit bb93b48 into open-mmlab:dev-1.x Jun 19, 2023
8 of 10 checks passed
@jinxianwei jinxianwei deleted the pr-dev-1.x branch July 19, 2023 09:40
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Thanks for your contribution and we appreciate it a lot. The following
instructions would make your pull request more healthy and more easily
get feedback. If you do not understand some items, don't worry, just
make the pull request and seek help from maintainers.

## Motivation

Add Huasdorff distance loss

---------

Co-authored-by: xiexinch <xiexinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants