Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix manifest #2828

Merged
merged 1 commit into from
Apr 3, 2023
Merged

[Fix] Fix manifest #2828

merged 1 commit into from
Apr 3, 2023

Conversation

xiexinch
Copy link
Collaborator

@xiexinch xiexinch commented Apr 3, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@xiexinch
Copy link
Collaborator Author

xiexinch commented Apr 3, 2023

@HAOCHENYE

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.36 🎉

Comparison is base (534b27b) 83.33% compared to head (135e4d7) 83.70%.

❗ Current head 135e4d7 differs from pull request most recent head 9e9d1cd. Consider uploading reports for the commit 9e9d1cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2828      +/-   ##
===========================================
+ Coverage    83.33%   83.70%   +0.36%     
===========================================
  Files          143      156      +13     
  Lines         8127     9355    +1228     
  Branches      1211     1373     +162     
===========================================
+ Hits          6773     7831    +1058     
- Misses        1165     1279     +114     
- Partials       189      245      +56     
Flag Coverage Δ
unittests 83.70% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/__init__.py 92.10% <ø> (ø)
mmseg/apis/__init__.py 100.00% <ø> (+100.00%) ⬆️
mmseg/apis/inference.py 23.15% <ø> (+23.15%) ⬆️
mmseg/apis/mmseg_inferencer.py 74.38% <ø> (ø)
mmseg/datasets/__init__.py 100.00% <ø> (ø)
mmseg/datasets/basesegdataset.py 100.00% <ø> (+1.02%) ⬆️
mmseg/datasets/dataset_wrappers.py 49.18% <ø> (ø)
mmseg/datasets/isaid.py 100.00% <ø> (ø)
mmseg/datasets/mapillary.py 91.66% <ø> (ø)
mmseg/datasets/refuge.py 100.00% <ø> (ø)
... and 23 more

... and 17 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch xiexinch merged commit 0e6f0e6 into open-mmlab:dev-1.x Apr 3, 2023
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants