Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support DSDL Dataset #2925

Merged
merged 2 commits into from May 10, 2023
Merged

Conversation

wufan-tb
Copy link
Contributor

  • support dsdl seg dataset
  • add dsdl dataset citest
  • validated accuracy on voc2012 and cityscapes

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

configs/dsdl/README.md Show resolved Hide resolved
mmseg/datasets/dsdl.py Outdated Show resolved Hide resolved
configs/dsdl/README.md Outdated Show resolved Hide resolved
configs/dsdl/cityscapes.py Show resolved Hide resolved
Comment on lines 13 to 14
train_ann = 'dsdl/set-train/train.yaml'
val_ann = 'dsdl/set-val/val.yaml'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we create the dsdl folder at mmsegmentation root path or at the datasets root path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this path will concate with root_path, so the actually path is "data/cityscapes/dsdl/set-train/train.yaml".

furthermore, here is a typical example of dsdl dataset's file struct :

data
└── VOC12-seg
    ├── dsdl
    └── original

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since users may not know how to use this dataset interface, could you write a document to introduce how to generate the train.yaml and val.yaml, or provide an example?

# dataset settings
dataset_type = 'DSDLSegDataset'
data_root = 'data/VOC12-seg'
img_prefix = 'original'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'original' a keyword needed inside DSDL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, users should change it by actual path. (or no img_prefix, decied by it's file sturct)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended not to use original and try to be consistent with https://github.com/open-mmlab/mmsegmentation/blob/main/configs/_base_/datasets/pascal_voc12_aug.py#L47, since other users may not notice this detail.

mmseg/datasets/dsdl.py Show resolved Hide resolved
mmseg/datasets/dsdl.py Outdated Show resolved Hide resolved
configs/dsdl/README.md Outdated Show resolved Hide resolved
Comment on lines 13 to 14
train_ann = 'dsdl/set-train/train.yaml'
val_ann = 'dsdl/set-val/val.yaml'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since users may not know how to use this dataset interface, could you write a document to introduce how to generate the train.yaml and val.yaml, or provide an example?

mmseg/datasets/dsdl.py Show resolved Hide resolved
# dataset settings
dataset_type = 'DSDLSegDataset'
data_root = 'data/VOC12-seg'
img_prefix = 'original'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is recommended not to use original and try to be consistent with https://github.com/open-mmlab/mmsegmentation/blob/main/configs/_base_/datasets/pascal_voc12_aug.py#L47, since other users may not notice this detail.

@wufan-tb wufan-tb force-pushed the dev-1.x-dsdl branch 4 times, most recently from 9d7876c to 8920dd4 Compare May 10, 2023 03:01
@xiexinch xiexinch merged commit b89c2c4 into open-mmlab:dev-1.x May 10, 2023
11 checks passed
@wufan-tb wufan-tb deleted the dev-1.x-dsdl branch May 12, 2023 00:53
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
- support dsdl seg dataset 
- add dsdl dataset citest
- validated accuracy on voc2012 and cityscapes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants