Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Added a supported for Visual Attention Network (VAN) #2987

Merged
merged 15 commits into from
May 22, 2023

Conversation

tang576225574
Copy link
Contributor

Motivation

The original version of Visual Attention Network (VAN) can be found from
https://github.com/Visual-Attention-Network/VAN-Segmentation
添加Visual Attention Network (VAN)的支持。

Modification

added a floder mmsegmentation/projects/van/
added 13 configs totally and aligned performance basically.
只增加了一个文件夹,共增加13个配置文件,基本对齐性能(没有全部跑)。

Use cases (Optional)

Before running, you may need to download the pretrain model from https://cloud.tsinghua.edu.cn/d/0100f0cea37d41ba8d08/
and then move them to the folder mmsegmentation/pretrained/, i.e. "mmsegmentation/pretrained/van_b2.pth".
After that, run the following command:
cd mmsegmentation
bash tools/dist_train.sh projects/van/configs/van/van-b2_pre1k_upernet_4xb2-160k_ade20k-512x512.py 4

@CLAassistant
Copy link

CLAassistant commented May 6, 2023

CLA assistant check
All committers have signed the CLA.

@csatsurnh
Copy link
Collaborator

Hi @tang576225574, thank you for your nice pr, but please sign the CLA first before we can review on it. Besides, can you also fix the lint please, thank you so much.

@tang576225574
Copy link
Contributor Author

Hi @tang576225574, thank you for your nice pr, but please sign the CLA first before we can review on it. Besides, can you also fix the lint please, thank you so much.

ok, I will fix it today.

@tang576225574
Copy link
Contributor Author

Hi @tang576225574, thank you for your nice pr, but please sign the CLA first before we can review on it. Besides, can you also fix the lint please, thank you so much.

lint had been fixed.

@xiexinch
Copy link
Collaborator

xiexinch commented May 11, 2023

Hi @tang576225574,
Thanks for your contribution!
Could you write a README for this project?

pad_val=0,
seg_pad_val=255,
size=(512, 512),
test_cfg=dict(size_divisor=32))
Copy link
Collaborator

@xiexinch xiexinch May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might remove this setting, since the official implementation uses Resize instead of Padding.
https://github.com/Visual-Attention-Network/VAN-Segmentation/blob/main/configs/_base_/datasets/ade20k.py#L28

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might remote this setting, since the official implementation uses Resize instead of Padding. https://github.com/Visual-Attention-Network/VAN-Segmentation/blob/main/configs/_base_/datasets/ade20k.py#L28

How to align this setting?
该怎么做?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在你的project的config目录下新建一个ade20k.py,重新写一个test_pipeline。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以在你的project的config目录下新建一个ade20k.py,重新写一个test_pipeline。

ok....

@tang576225574
Copy link
Contributor Author

Hi @tang576225574, Thanks for your contribution! Could you write a README for this project?

of course! I will write a README in the next commit, about 3 days.

@tang576225574
Copy link
Contributor Author

Fixed!

@xiexinch xiexinch changed the title Added a supported for Visual Attention Network (VAN) [Project] Added a supported for Visual Attention Network (VAN) May 22, 2023
@xiexinch xiexinch merged commit 0bfe255 into open-mmlab:dev-1.x May 22, 2023
2 checks passed
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
…mmlab#2987)

## Motivation
The original version of Visual Attention Network (VAN) can be found from
https://github.com/Visual-Attention-Network/VAN-Segmentation
添加Visual Attention Network (VAN)的支持。



## Modification
added a floder mmsegmentation/projects/van/
added 13 configs totally and aligned performance basically.
只增加了一个文件夹,共增加13个配置文件,基本对齐性能(没有全部跑)。


## Use cases (Optional)
Before running, you may need to download the pretrain model from
https://cloud.tsinghua.edu.cn/d/0100f0cea37d41ba8d08/
and then move them to the folder mmsegmentation/pretrained/, i.e.
"mmsegmentation/pretrained/van_b2.pth".
After that, run the following command:
    cd mmsegmentation
bash tools/dist_train.sh
projects/van/configs/van/van-b2_pre1k_upernet_4xb2-160k_ade20k-512x512.py
4

---------

Co-authored-by: xiexinch <xiexinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants