Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor dice loss #3002

Merged
merged 7 commits into from
May 15, 2023
Merged

Conversation

csatsurnh
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

xiexinch and others added 4 commits April 26, 2023 10:14
## Motivation

Update repo information and URLs in README.

## Modification


## BC-breaking (Optional)


## Use cases (Optional)

---------

Co-authored-by: CSH <40987381+csatsurnh@users.noreply.github.com>
@csatsurnh csatsurnh changed the title [Refactor] Refactor dice loss [WIP][Refactor] Refactor dice loss May 10, 2023
@xiexinch xiexinch changed the title [WIP][Refactor] Refactor dice loss [Refactor] Refactor dice loss May 15, 2023
@xiexinch xiexinch merged commit 2f257ab into open-mmlab:dev-1.x May 15, 2023
2 checks passed
@LHamnett
Copy link
Contributor

@csatsurnh @xiexinch , can I confirm it was intentional to remove the class weight variable from the refactored DiceLoss?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants