Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Update confusion_matrix.py #3291

Merged
merged 11 commits into from
Aug 31, 2023
Merged

[Fix] Update confusion_matrix.py #3291

merged 11 commits into from
Aug 31, 2023

Conversation

XDWang97
Copy link
Contributor

Motivation

Modification

The confusion_matrix.py is not compatible with the current version of mmseg.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@XDWang97 XDWang97 closed this Aug 28, 2023
@XDWang97 XDWang97 reopened this Aug 29, 2023
@xiexinch
Copy link
Collaborator

Hi @XiandongWang,
Thanks for your contribution! Please fix the lint error, we'll merge it ASAP.

@xiexinch xiexinch changed the base branch from main to dev-1.x August 30, 2023 02:23
@xiexinch xiexinch changed the title Update confusion_matrix.py [Fix] Update confusion_matrix.py Aug 30, 2023
@OpenMMLab-Assistant-004
Copy link

Hi @XiandongWang,

We'd like to express our appreciation for your valuable contributions to the mmsegmentation. Your efforts have significantly aided in enhancing the project's quality.
It is our pleasure to invite you to join our community thorugh Discord_Special Interest Group (SIG) channel. This is a great place to share your experiences, discuss ideas, and connect with other like-minded people. To become a part of the SIG channel, send a message to the moderator, OpenMMLab, briefly introduce yourself and mention your open-source contributions in the #introductions channel. Our team will gladly facilitate your entry. We eagerly await your presence. Please follow this link to join us: ​https://discord.gg/UjgXkPWNqA.

If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID".

Thanks again for your awesome contribution, and we're excited to have you as part of our community!

@XDWang97
Copy link
Contributor Author

Hi @XiandongWang, Thanks for your contribution! Please fix the lint error, we'll merge it ASAP.

Hi, I've tried a few times, but I keep failing due to this error: 'isort Failed.' Could you give me some advice, please?

@xiexinch
Copy link
Collaborator

Hi @XiandongWang, Thanks for your contribution! Please fix the lint error, we'll merge it ASAP.

Hi, I've tried a few times, but I keep failing due to this error: 'isort Failed.' Could you give me some advice, please?

Hi, I've fixed it. We'll run some tests then this PR will be merged.

@XDWang97
Copy link
Contributor Author

Hi @XiandongWang, Thanks for your contribution! Please fix the lint error, we'll merge it ASAP.

Hi, I've tried a few times, but I keep failing due to this error: 'isort Failed.' Could you give me some advice, please?

Hi, I've fixed it. We'll run some tests then this PR will be merged.

Thanks!

xiexinch
xiexinch reviewed Aug 31, 2023
View reviewed changes
tools/analysis_tools/confusion_matrix.py Outdated Show resolved Hide resolved
tools/analysis_tools/confusion_matrix.py
@@ -89,14 +98,16 @@ def plot_confusion_matrix(confusion_matrix,

num_classes = len(labels)
fig, ax = plt.subplots(
figsize=(2 * num_classes, 2 * num_classes * 0.8), dpi=180)
figsize=(2 * num_classes, 2 * num_classes * 0.8), dpi=300)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should add a parameter to control the dpi, it's too large for ADE20K dataset.

tools/analysis_tools/confusion_matrix.py Outdated Show resolved Hide resolved
tools/analysis_tools/confusion_matrix.py Outdated Show resolved Hide resolved
tools/analysis_tools/confusion_matrix.py Outdated Show resolved Hide resolved
@xiexinch xiexinch merged commit ebd5695 into open-mmlab:dev-1.x Aug 31, 2023
3 of 7 checks passed
emily-lin pushed a commit to emily-lin/mmsegmentation that referenced this pull request Nov 18, 2023
@XDWang97 @xiexinch @weichengkuo
[Fix] Update confusion_matrix.py (open-mmlab#3291)
486b147 
## Motivation



## Modification

The confusion_matrix.py is not compatible with the current version of
mmseg.

---------

Co-authored-by: xiexinch <xiexinch@outlook.com>
nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
@XDWang97 @xiexinch
[Fix] Update confusion_matrix.py (open-mmlab#3291)
2bf6b6e 
## Motivation



## Modification

The confusion_matrix.py is not compatible with the current version of
mmseg.

---------

Co-authored-by: xiexinch <xiexinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiexinch xiexinch xiexinch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XDWang97 @CLAassistant @xiexinch @OpenMMLab-Assistant-004