Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Refine the docstring of ResNet #723

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

Junjun2016
Copy link
Collaborator

Motivation

Some args of ResNet in the docstring are missing.
Some default values of args are also missing

Modification

Docstring of ResNet

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No

@Junjun2016 Junjun2016 requested a review from xvjiarui July 25, 2021 10:31
@codecov
Copy link

codecov bot commented Jul 25, 2021

Codecov Report

Merging #723 (813fd66) into master (4d34581) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files         107      107           
  Lines        5817     5817           
  Branches      952      952           
=======================================
  Hits         4961     4961           
  Misses        673      673           
  Partials      183      183           
Flag Coverage Δ
unittests 85.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/resnet.py 99.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d34581...813fd66. Read the comment docs.

@Junjun2016 Junjun2016 requested review from xiexinch and removed request for xvjiarui July 28, 2021 08:56
@Junjun2016 Junjun2016 merged commit fa1554f into open-mmlab:master Jul 28, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* refine docstring of resnet

* refine docstring
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* Fix 722

* add unittest and update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants